You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/07/19 03:46:52 UTC
Review Request 23704: Fixed header paths for proto files during installation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23704/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy St. Clair.
Repository: mesos-git
Description
-------
Playing with installed mesos headers, realized that we expect users to include the path to mesos directory (e.g., /usr/local/include/mesos) even though it is on the system path. This is because scheduler.pb.h etc include "mesos.pb.h" instead of "mesos/mesos.pb.h".
Diffs
-----
include/mesos/containerizer/containerizer.proto 29df785ec6f86b6371c8e2a23871be2c7284e5cd
include/mesos/scheduler/scheduler.proto 6ab5089f14e82f165b6b87ecfc38a3d9a247ce88
src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25
src/master/registry.proto 8ca4e2fa12a46c149ba5561235416e96f262902a
src/messages/messages.proto 0d63dc17b9815e0b6c86d6ce726163287693d6dd
Diff: https://reviews.apache.org/r/23704/diff/
Testing
-------
make
Thanks,
Vinod Kone
Re: Review Request 23704: Fixed header paths for proto files during
installation.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23704/#review48520
-----------------------------------------------------------
Ship it!
We should add to release notes the inclusion change for framework developers, in the off case they prefix install Mesos ;-)
- Timothy St. Clair
On July 22, 2014, 9:30 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23704/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 9:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy St. Clair.
>
>
> Bugs: MESOS-1627
> https://issues.apache.org/jira/browse/MESOS-1627
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Playing with installed mesos headers, realized that we expect users to include the path to mesos directory (e.g., /usr/local/include/mesos) even though it is on the system path. This is because scheduler.pb.h etc include "mesos.pb.h" instead of "mesos/mesos.pb.h".
>
>
> Diffs
> -----
>
> include/mesos/containerizer/containerizer.proto 29df785ec6f86b6371c8e2a23871be2c7284e5cd
> include/mesos/scheduler/scheduler.proto 6ab5089f14e82f165b6b87ecfc38a3d9a247ce88
> src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25
> src/master/registry.proto 8ca4e2fa12a46c149ba5561235416e96f262902a
> src/messages/messages.proto 0d63dc17b9815e0b6c86d6ce726163287693d6dd
>
> Diff: https://reviews.apache.org/r/23704/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23704: Fixed header paths for proto files during
installation.
Posted by Zuyu Zhang <hi...@gmail.com>.
> On July 22, 2014, 9:33 p.m., Dominic Hamon wrote:
> > If anyone is already building C++ frameworks, they'll have an extra include path in their build script after this, with the 'mesos' path included, right? This shouldn't break them as far as I can see. Is that assumption correct?
I think, with this patch, build scripts for C++ frameworks do not have to include 'mesos' path any more. Btw, this is related to MESOS-1504.
- Zuyu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23704/#review48436
-----------------------------------------------------------
On July 22, 2014, 9:30 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23704/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 9:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy St. Clair.
>
>
> Bugs: MESOS-1627
> https://issues.apache.org/jira/browse/MESOS-1627
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Playing with installed mesos headers, realized that we expect users to include the path to mesos directory (e.g., /usr/local/include/mesos) even though it is on the system path. This is because scheduler.pb.h etc include "mesos.pb.h" instead of "mesos/mesos.pb.h".
>
>
> Diffs
> -----
>
> include/mesos/containerizer/containerizer.proto 29df785ec6f86b6371c8e2a23871be2c7284e5cd
> include/mesos/scheduler/scheduler.proto 6ab5089f14e82f165b6b87ecfc38a3d9a247ce88
> src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25
> src/master/registry.proto 8ca4e2fa12a46c149ba5561235416e96f262902a
> src/messages/messages.proto 0d63dc17b9815e0b6c86d6ce726163287693d6dd
>
> Diff: https://reviews.apache.org/r/23704/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23704: Fixed header paths for proto files during
installation.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23704/#review48436
-----------------------------------------------------------
Ship it!
If anyone is already building C++ frameworks, they'll have an extra include path in their build script after this, with the 'mesos' path included, right? This shouldn't break them as far as I can see. Is that assumption correct?
- Dominic Hamon
On July 22, 2014, 2:30 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23704/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 2:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy St. Clair.
>
>
> Bugs: MESOS-1627
> https://issues.apache.org/jira/browse/MESOS-1627
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Playing with installed mesos headers, realized that we expect users to include the path to mesos directory (e.g., /usr/local/include/mesos) even though it is on the system path. This is because scheduler.pb.h etc include "mesos.pb.h" instead of "mesos/mesos.pb.h".
>
>
> Diffs
> -----
>
> include/mesos/containerizer/containerizer.proto 29df785ec6f86b6371c8e2a23871be2c7284e5cd
> include/mesos/scheduler/scheduler.proto 6ab5089f14e82f165b6b87ecfc38a3d9a247ce88
> src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25
> src/master/registry.proto 8ca4e2fa12a46c149ba5561235416e96f262902a
> src/messages/messages.proto 0d63dc17b9815e0b6c86d6ce726163287693d6dd
>
> Diff: https://reviews.apache.org/r/23704/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23704: Fixed header paths for proto files during
installation.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23704/
-----------------------------------------------------------
(Updated July 22, 2014, 9:30 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy St. Clair.
Changes
-------
added bug. PTAL.
Bugs: MESOS-1627
https://issues.apache.org/jira/browse/MESOS-1627
Repository: mesos-git
Description
-------
Playing with installed mesos headers, realized that we expect users to include the path to mesos directory (e.g., /usr/local/include/mesos) even though it is on the system path. This is because scheduler.pb.h etc include "mesos.pb.h" instead of "mesos/mesos.pb.h".
Diffs
-----
include/mesos/containerizer/containerizer.proto 29df785ec6f86b6371c8e2a23871be2c7284e5cd
include/mesos/scheduler/scheduler.proto 6ab5089f14e82f165b6b87ecfc38a3d9a247ce88
src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25
src/master/registry.proto 8ca4e2fa12a46c149ba5561235416e96f262902a
src/messages/messages.proto 0d63dc17b9815e0b6c86d6ce726163287693d6dd
Diff: https://reviews.apache.org/r/23704/diff/
Testing
-------
make
Thanks,
Vinod Kone