You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/18 03:37:40 UTC

[GitHub] [flink] godfreyhe edited a comment on issue #9146: [FLINK-13284] [table-planner-blink] Correct some builtin functions' r…

godfreyhe edited a comment on issue #9146: [FLINK-13284] [table-planner-blink] Correct some builtin functions' r…
URL: https://github.com/apache/flink/pull/9146#issuecomment-512651957
 
 
   Thanks for this PR @lincoln-lil . for stream job, I think "return null" is the general case (maybe for some special cases, users also want "throw exception" when processing illegal data). while for batch job, "throw exception" is more general ?!  for the long term, maybe we should add a config to let users choose the mode. for this PR, it looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services