You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/28 12:54:00 UTC
[jira] [Commented] (IGNITE-8407) Wrong memory size printing in
IgniteCacheDatabaseSnaredManager
[ https://issues.apache.org/jira/browse/IGNITE-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457577#comment-16457577 ]
ASF GitHub Bot commented on IGNITE-8407:
----------------------------------------
GitHub user snuyanzin opened a pull request:
https://github.com/apache/ignite/pull/3936
IGNITE-8407 Wrong memory size printing in IgniteCacheDatabaseSnaredManager
usages of getInitialSize()/getMaxSize()) should go with U.readableSize(*, false)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuyanzin/ignite IGNITE-8407_Wrong_memory_size_printing_in_IgniteCacheDatabaseSnaredManager
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3936.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3936
----
commit 0760b1521fbd5a333066a3acafd601ca7e4c8b4e
Author: snuyanzin <sn...@...>
Date: 2018-04-28T12:48:52Z
IGNITE-8407 Wrong memory size printing in IgniteCacheDatabaseSnaredManager
usages of getInitialSize()/getMaxSize()) should go with U.readableSize(*, true)
----
> Wrong memory size printing in IgniteCacheDatabaseSnaredManager
> --------------------------------------------------------------
>
> Key: IGNITE-8407
> URL: https://issues.apache.org/jira/browse/IGNITE-8407
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 2.4
> Reporter: Alexander Belyak
> Priority: Trivial
>
> In checkDataRegionSize regCfg printing in "si" format (based on 1000, not 1024). Need to fix it and any other usages of getInitialSize()/getMaxSize()) with U.readableSize(*, true)
> {noformat}
> throw new IgniteCheckedException("DataRegion must have size more than 10MB (use " +
> "DataRegionConfiguration.initialSize and .maxSize properties to set correct size in bytes) " +
> "[name=" + regCfg.getName() + ", initialSize=" + U.readableSize(regCfg.getInitialSize(), true) +
> ", maxSize=" + U.readableSize(regCfg.getMaxSize(), true) + "]"
> {noformat}
> should be replaced with
> {noformat}
> throw new IgniteCheckedException("DataRegion must have size more than 10MB (use " +
> "DataRegionConfiguration.initialSize and .maxSize properties to set correct size in bytes) " +
> "[name=" + regCfg.getName() + ", initialSize=" + U.readableSize(regCfg.getInitialSize(), false) +
> ", maxSize=" + U.readableSize(regCfg.getMaxSize(), false) + "]"
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)