You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/03 01:30:26 UTC

[kudu-CR] [mini chronyd] introduce MiniChronyd::address()

Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14355

to look at the new patch set (#2).

Change subject: [mini_chronyd] introduce MiniChronyd::address()
......................................................................

[mini_chronyd] introduce MiniChronyd::address()

Introduced MiniChronyd::address() method to find IP address and port
at which the underlying NTP server is listening for incoming requests.
In case if the NTP server is bound to the wildcard address, use the
loopback address for NTP communication with the server.

Also, updated corresponding call sites to use the new method instead of
accessing MiniChronyd's options.

Prior to this patch, the ToolTest.TestRemoteReplicaCopy test scenario
would fail if running with built-in NTP client enabled.

Change-Id: I62a326a47160aefe9a5806162e6df7c4d6060ba5
---
M src/kudu/clock/ntp-test.cc
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd.cc
M src/kudu/clock/test/mini_chronyd.h
M src/kudu/mini-cluster/external_mini_cluster.cc
5 files changed, 28 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/14355/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I62a326a47160aefe9a5806162e6df7c4d6060ba5
Gerrit-Change-Number: 14355
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)