You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "pandalee99 (via GitHub)" <gi...@apache.org> on 2025/02/05 14:23:52 UTC
[PR] feat(python): Implement Map type prediction and Chunk transfer in pyfury [fury]
pandalee99 opened a new pull request, #2037:
URL: https://github.com/apache/fury/pull/2037
<!--
**Thanks for contributing to Fury.**
**If this is your first time opening a PR on fury, you can refer to [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**
Contribution Checklist
- The **Apache Fury (incubating)** community has restrictions on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).
- Fury has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here.
-->
## What does this PR do?
<!-- Describe the purpose of this PR. -->
## Related issues
#1935
<!--
Is there any related issue? Please attach here.
- #xxxx0
- #xxxx1
- #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an issue](https://github.com/apache/fury/issues/new/choose) describing the need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "pandalee99 (via GitHub)" <gi...@apache.org>.
pandalee99 commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1944242190
##########
python/pyfury/_serializer.py:
##########
@@ -294,39 +298,219 @@ def __init__(self, fury, type_, key_serializer=None, value_serializer=None):
self.key_serializer = key_serializer
self.value_serializer = value_serializer
- def write(self, buffer, value: Dict):
- buffer.write_varuint32(len(value))
- for k, v in value.items():
- key_cls = type(k)
- if key_cls is str:
- buffer.write_int16(NOT_NULL_STRING_FLAG)
- buffer.write_string(k)
+ def write(self, buffer, o):
+ obj = o
+ length = len(obj)
+ buffer.write_varuint32(length)
+ if length == 0:
+ return
+ fury = self.fury
+ class_resolver = fury.class_resolver
+ ref_resolver = fury.ref_resolver
+ key_serializer = self.key_serializer
+ value_serializer = self.value_serializer
+ pos = 0
+ items = list(obj.items())
+ while pos < len(items):
+ key, value = items[pos]
+ pos += 1
+ if key is not None:
+ if value is not None:
+ break
+ if key_serializer is not None:
+ if key_serializer.need_to_write_ref:
+ buffer.write_int8(NULL_VALUE_KEY_DECL_TYPE_TRACKING_REF)
+ if not self.ref_resolver.write_ref_or_null(buffer, key):
+ key_serializer.write(buffer, key)
+ else:
+ buffer.write_int8(NULL_VALUE_KEY_DECL_TYPE)
+ key_serializer.write(buffer, key)
+ else:
+ buffer.write_int8(VALUE_HAS_NULL | TRACKING_KEY_REF)
+ fury.serialize_ref(buffer, key)
else:
- if not self.ref_resolver.write_ref_or_null(buffer, k):
- classinfo = self.class_resolver.get_classinfo(key_cls)
- self.class_resolver.write_typeinfo(buffer, classinfo)
- classinfo.serializer.write(buffer, k)
- value_cls = type(v)
- if value_cls is str:
- buffer.write_int16(NOT_NULL_STRING_FLAG)
- buffer.write_string(v)
- elif value_cls is int:
- buffer.write_int16(NOT_NULL_INT64_FLAG)
- buffer.write_varint64(v)
+ if value is not None:
+ if value_serializer is not None:
+ if value_serializer.need_to_write_ref:
+ buffer.write_int8(NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF)
+ if not self.ref_resolver.write_ref_or_null(buffer, key):
+ value_serializer.write(buffer, key)
+ if not self.ref_resolver.write_ref_or_null(buffer, value):
+ value_serializer.write(buffer, value)
+ else:
+ buffer.write_int8(NULL_KEY_VALUE_DECL_TYPE)
+ value_serializer.write(buffer, value)
+ else:
+ buffer.write_int8(KEY_HAS_NULL | TRACKING_VALUE_REF)
+ fury.serialize_ref(buffer, value)
+ else:
+ buffer.write_int8(KV_NULL)
+ if pos >= len(items):
+ break
+ key_cls = type(key)
+ value_cls = type(value)
+ buffer.write_int16(-1)
+ chunk_size_offset = buffer.writer_index - 1
+ chunk_header = 0
+ if key_serializer is not None:
+ chunk_header |= KEY_DECL_TYPE
else:
- if not self.ref_resolver.write_ref_or_null(buffer, v):
- classinfo = self.class_resolver.get_classinfo(value_cls)
- self.class_resolver.write_typeinfo(buffer, classinfo)
- classinfo.serializer.write(buffer, v)
+ key_classinfo = self.class_resolver.get_classinfo(key_cls)
+ class_resolver.write_typeinfo(buffer, key_classinfo)
+ key_serializer = key_classinfo.serializer
+ if value_serializer is not None:
+ chunk_header |= VALUE_DECL_TYPE
+ else:
+ value_classinfo = self.class_resolver.get_classinfo(value_cls)
+ class_resolver.write_typeinfo(buffer, value_classinfo)
+ value_serializer = value_classinfo.serializer
+ key_write_ref = key_serializer.need_to_write_ref
+ value_write_ref = value_serializer.need_to_write_ref
+ if key_write_ref:
+ chunk_header |= TRACKING_KEY_REF
+ if value_write_ref:
+ chunk_header |= TRACKING_VALUE_REF
+ buffer.put_int8(chunk_size_offset - 1, chunk_header)
+ key_serializer_type = type(key_serializer)
+ value_serializer_type = type(value_serializer)
+ chunk_size = 0
+ while True:
+ if (key is None or value is None or
+ type(key) is not key_cls or type(value) is not value_cls):
+ break
+ if not key_write_ref or not ref_resolver.write_ref_or_null(buffer, key):
+ if key_cls is str:
Review Comment:
But users might not be smart enough, and if there's a bit of inconsistency in the code, they won't be able to clearly recognize the problem. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): chunk based map serialization in pure python [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #2037:
URL: https://github.com/apache/fury/pull/2037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1944220875
##########
python/pyfury/_serializer.py:
##########
@@ -294,39 +298,219 @@ def __init__(self, fury, type_, key_serializer=None, value_serializer=None):
self.key_serializer = key_serializer
self.value_serializer = value_serializer
- def write(self, buffer, value: Dict):
- buffer.write_varuint32(len(value))
- for k, v in value.items():
- key_cls = type(k)
- if key_cls is str:
- buffer.write_int16(NOT_NULL_STRING_FLAG)
- buffer.write_string(k)
+ def write(self, buffer, o):
+ obj = o
+ length = len(obj)
+ buffer.write_varuint32(length)
+ if length == 0:
+ return
+ fury = self.fury
+ class_resolver = fury.class_resolver
+ ref_resolver = fury.ref_resolver
+ key_serializer = self.key_serializer
+ value_serializer = self.value_serializer
+ pos = 0
+ items = list(obj.items())
+ while pos < len(items):
+ key, value = items[pos]
+ pos += 1
+ if key is not None:
+ if value is not None:
+ break
+ if key_serializer is not None:
+ if key_serializer.need_to_write_ref:
+ buffer.write_int8(NULL_VALUE_KEY_DECL_TYPE_TRACKING_REF)
+ if not self.ref_resolver.write_ref_or_null(buffer, key):
+ key_serializer.write(buffer, key)
+ else:
+ buffer.write_int8(NULL_VALUE_KEY_DECL_TYPE)
+ key_serializer.write(buffer, key)
+ else:
+ buffer.write_int8(VALUE_HAS_NULL | TRACKING_KEY_REF)
+ fury.serialize_ref(buffer, key)
else:
- if not self.ref_resolver.write_ref_or_null(buffer, k):
- classinfo = self.class_resolver.get_classinfo(key_cls)
- self.class_resolver.write_typeinfo(buffer, classinfo)
- classinfo.serializer.write(buffer, k)
- value_cls = type(v)
- if value_cls is str:
- buffer.write_int16(NOT_NULL_STRING_FLAG)
- buffer.write_string(v)
- elif value_cls is int:
- buffer.write_int16(NOT_NULL_INT64_FLAG)
- buffer.write_varint64(v)
+ if value is not None:
+ if value_serializer is not None:
+ if value_serializer.need_to_write_ref:
+ buffer.write_int8(NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF)
+ if not self.ref_resolver.write_ref_or_null(buffer, key):
+ value_serializer.write(buffer, key)
+ if not self.ref_resolver.write_ref_or_null(buffer, value):
+ value_serializer.write(buffer, value)
+ else:
+ buffer.write_int8(NULL_KEY_VALUE_DECL_TYPE)
+ value_serializer.write(buffer, value)
+ else:
+ buffer.write_int8(KEY_HAS_NULL | TRACKING_VALUE_REF)
+ fury.serialize_ref(buffer, value)
+ else:
+ buffer.write_int8(KV_NULL)
+ if pos >= len(items):
+ break
+ key_cls = type(key)
+ value_cls = type(value)
+ buffer.write_int16(-1)
+ chunk_size_offset = buffer.writer_index - 1
+ chunk_header = 0
+ if key_serializer is not None:
+ chunk_header |= KEY_DECL_TYPE
else:
- if not self.ref_resolver.write_ref_or_null(buffer, v):
- classinfo = self.class_resolver.get_classinfo(value_cls)
- self.class_resolver.write_typeinfo(buffer, classinfo)
- classinfo.serializer.write(buffer, v)
+ key_classinfo = self.class_resolver.get_classinfo(key_cls)
+ class_resolver.write_typeinfo(buffer, key_classinfo)
+ key_serializer = key_classinfo.serializer
+ if value_serializer is not None:
+ chunk_header |= VALUE_DECL_TYPE
+ else:
+ value_classinfo = self.class_resolver.get_classinfo(value_cls)
+ class_resolver.write_typeinfo(buffer, value_classinfo)
+ value_serializer = value_classinfo.serializer
+ key_write_ref = key_serializer.need_to_write_ref
+ value_write_ref = value_serializer.need_to_write_ref
+ if key_write_ref:
+ chunk_header |= TRACKING_KEY_REF
+ if value_write_ref:
+ chunk_header |= TRACKING_VALUE_REF
+ buffer.put_int8(chunk_size_offset - 1, chunk_header)
+ key_serializer_type = type(key_serializer)
+ value_serializer_type = type(value_serializer)
+ chunk_size = 0
+ while True:
+ if (key is None or value is None or
+ type(key) is not key_cls or type(value) is not value_cls):
+ break
+ if not key_write_ref or not ref_resolver.write_ref_or_null(buffer, key):
+ if key_cls is str:
Review Comment:
The pure python implementation is used for debug only, we can remove all fastpath, just keep the most simple implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): chunk based map serialization in pure python [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2037:
URL: https://github.com/apache/fury/pull/2037#issuecomment-2654121386
Hi @pandalee99 , please replace read_buffer_object with:
```python
def read_buffer_object(self, buffer) -> Buffer:
in_band = buffer.read_bool()
if in_band:
size = buffer.read_varuint32()
buf = buffer.slice(buffer.reader_index, size)
buffer.reader_index += size
return buf
else:
assert self._buffers is not None
return next(self._buffers)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1944350109
##########
python/pyfury/_fury.py:
##########
@@ -82,11 +82,15 @@
# Key is null, value type is declared type, and ref tracking for value is disabled.
NULL_KEY_VALUE_DECL_TYPE = KEY_HAS_NULL | VALUE_DECL_TYPE
# Key is null, value type is declared type, and ref tracking for value is enabled.
-NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF = KEY_HAS_NULL | VALUE_DECL_TYPE | TRACKING_VALUE_REF
+NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF = (
Review Comment:
could we reserve those parameters in _serializer.py, it's used by map serializer only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): chunk based map serialization in pure python [fury]
Posted by "pandalee99 (via GitHub)" <gi...@apache.org>.
pandalee99 commented on PR #2037:
URL: https://github.com/apache/fury/pull/2037#issuecomment-2650891061
hi, shawn! @chaokunyang
In the pure python, MapSerializer is be done.
But there are a error that are not about MapSerializer. Because of the add of `ci/run_ci.sh`, there are error left over from history `test_serialize_arrow():`, can you help me solve them?
<img width="495" alt="image" src="https://github.com/user-attachments/assets/8202eb2e-7e8d-47fa-bd6b-8f1f82c2b8bc" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "pandalee99 (via GitHub)" <gi...@apache.org>.
pandalee99 commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1943243116
##########
python/pyfury/_serializer.py:
##########
@@ -285,6 +287,7 @@ class MapSerializer(Serializer):
"ref_resolver",
"key_serializer",
"value_serializer",
+ "use_chunk_serialize",
Review Comment:
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1944244102
##########
python/pyfury/_serializer.py:
##########
@@ -294,39 +298,219 @@ def __init__(self, fury, type_, key_serializer=None, value_serializer=None):
self.key_serializer = key_serializer
self.value_serializer = value_serializer
- def write(self, buffer, value: Dict):
- buffer.write_varuint32(len(value))
- for k, v in value.items():
- key_cls = type(k)
- if key_cls is str:
- buffer.write_int16(NOT_NULL_STRING_FLAG)
- buffer.write_string(k)
+ def write(self, buffer, o):
+ obj = o
+ length = len(obj)
+ buffer.write_varuint32(length)
+ if length == 0:
+ return
+ fury = self.fury
+ class_resolver = fury.class_resolver
+ ref_resolver = fury.ref_resolver
+ key_serializer = self.key_serializer
+ value_serializer = self.value_serializer
+ pos = 0
+ items = list(obj.items())
+ while pos < len(items):
+ key, value = items[pos]
+ pos += 1
+ if key is not None:
+ if value is not None:
+ break
+ if key_serializer is not None:
+ if key_serializer.need_to_write_ref:
+ buffer.write_int8(NULL_VALUE_KEY_DECL_TYPE_TRACKING_REF)
+ if not self.ref_resolver.write_ref_or_null(buffer, key):
+ key_serializer.write(buffer, key)
+ else:
+ buffer.write_int8(NULL_VALUE_KEY_DECL_TYPE)
+ key_serializer.write(buffer, key)
+ else:
+ buffer.write_int8(VALUE_HAS_NULL | TRACKING_KEY_REF)
+ fury.serialize_ref(buffer, key)
else:
- if not self.ref_resolver.write_ref_or_null(buffer, k):
- classinfo = self.class_resolver.get_classinfo(key_cls)
- self.class_resolver.write_typeinfo(buffer, classinfo)
- classinfo.serializer.write(buffer, k)
- value_cls = type(v)
- if value_cls is str:
- buffer.write_int16(NOT_NULL_STRING_FLAG)
- buffer.write_string(v)
- elif value_cls is int:
- buffer.write_int16(NOT_NULL_INT64_FLAG)
- buffer.write_varint64(v)
+ if value is not None:
+ if value_serializer is not None:
+ if value_serializer.need_to_write_ref:
+ buffer.write_int8(NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF)
+ if not self.ref_resolver.write_ref_or_null(buffer, key):
+ value_serializer.write(buffer, key)
+ if not self.ref_resolver.write_ref_or_null(buffer, value):
+ value_serializer.write(buffer, value)
+ else:
+ buffer.write_int8(NULL_KEY_VALUE_DECL_TYPE)
+ value_serializer.write(buffer, value)
+ else:
+ buffer.write_int8(KEY_HAS_NULL | TRACKING_VALUE_REF)
+ fury.serialize_ref(buffer, value)
+ else:
+ buffer.write_int8(KV_NULL)
+ if pos >= len(items):
+ break
+ key_cls = type(key)
+ value_cls = type(value)
+ buffer.write_int16(-1)
+ chunk_size_offset = buffer.writer_index - 1
+ chunk_header = 0
+ if key_serializer is not None:
+ chunk_header |= KEY_DECL_TYPE
else:
- if not self.ref_resolver.write_ref_or_null(buffer, v):
- classinfo = self.class_resolver.get_classinfo(value_cls)
- self.class_resolver.write_typeinfo(buffer, classinfo)
- classinfo.serializer.write(buffer, v)
+ key_classinfo = self.class_resolver.get_classinfo(key_cls)
+ class_resolver.write_typeinfo(buffer, key_classinfo)
+ key_serializer = key_classinfo.serializer
+ if value_serializer is not None:
+ chunk_header |= VALUE_DECL_TYPE
+ else:
+ value_classinfo = self.class_resolver.get_classinfo(value_cls)
+ class_resolver.write_typeinfo(buffer, value_classinfo)
+ value_serializer = value_classinfo.serializer
+ key_write_ref = key_serializer.need_to_write_ref
+ value_write_ref = value_serializer.need_to_write_ref
+ if key_write_ref:
+ chunk_header |= TRACKING_KEY_REF
+ if value_write_ref:
+ chunk_header |= TRACKING_VALUE_REF
+ buffer.put_int8(chunk_size_offset - 1, chunk_header)
+ key_serializer_type = type(key_serializer)
+ value_serializer_type = type(value_serializer)
+ chunk_size = 0
+ while True:
+ if (key is None or value is None or
+ type(key) is not key_cls or type(value) is not value_cls):
+ break
+ if not key_write_ref or not ref_resolver.write_ref_or_null(buffer, key):
+ if key_cls is str:
Review Comment:
Users will use cython mode only, python mode is used only when there are some deserialization error which needs debug line by line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): chunk based map serialization in pure python [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2037:
URL: https://github.com/apache/fury/pull/2037#issuecomment-2640019506

chunk map serialization still fail when cython disabled @pandalee99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1943236090
##########
python/pyfury/_serializer.py:
##########
@@ -285,6 +287,7 @@ class MapSerializer(Serializer):
"ref_resolver",
"key_serializer",
"value_serializer",
+ "use_chunk_serialize",
Review Comment:
this is unnecessary, we can just switch to chunk serialization directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(python): Implement Chunk by chunk predictive map serialization in pyfury [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2037:
URL: https://github.com/apache/fury/pull/2037#discussion_r1943236090
##########
python/pyfury/_serializer.py:
##########
@@ -285,6 +287,7 @@ class MapSerializer(Serializer):
"ref_resolver",
"key_serializer",
"value_serializer",
+ "use_chunk_serialize",
Review Comment:
this is unnecessary, we can just use chunk serialization directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org