You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Nikita (JIRA)" <ji...@apache.org> on 2008/04/23 22:21:21 UTC
[jira] Created: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
-------------------------------------------------------------------------------------------------------------------
Key: PLUTO-484
URL: https://issues.apache.org/jira/browse/PLUTO-484
Project: Pluto
Issue Type: Bug
Components: portlet container
Affects Versions: 1.1.5
Environment: Tomcat 5.5.26
Reporter: Nikita
The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
public void setSecure(boolean secure) throws PortletSecurityException {
PortletURLProvider urlProvider = container
.getRequiredContainerServices()
.getPortalCallbackService()
.getPortletURLProvider(servletRequest, internalPortletWindow);
if(urlProvider.isSecureSupported()) {
throw new PortletSecurityException("Secure URLs not supported.");
}
}
The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
public void setSecure(boolean secure) throws PortletSecurityException {
if(!secure) {
return;
}
PortletURLProvider urlProvider = container
.getRequiredContainerServices()
.getPortalCallbackService()
.getPortletURLProvider(servletRequest, internalPortletWindow);
if(urlProvider.isSecureSupported()) {
urlProvider.setSecure();
} else {
throw new PortletSecurityException("Secure URLs not supported.");
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Doremus reopened PLUTO-484:
---------------------------------
Assignee: Craig Doremus
This change causes an Exception to be thrown at line 189 in BaseURLImpl (of SVN trunk) when Pluto is deployed in Tomcat.
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 2.0.0, 2.0-refactoring, 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita Dubrovsky
> Assignee: Craig Doremus
> Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated PLUTO-484:
-------------------------------
Attachment: P484-1.1.x-Rev652071.diff
Updated patch crated against 1.1.x branch (Rev643117), which includes a required update to pluto-container/src/main/java/org/apache/pluto/core/PortletContainerImpl.java
Verified by using latest Geronimo 2.1.2 build and access our Admin Console via HTTPS (port 8443 in our server.)
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita
> Fix For: 2.0.0, 1.1.6
>
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated PLUTO-484:
-------------------------------
Fix Version/s: 1.1.6
2.0.0
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita
> Fix For: 2.0.0, 1.1.6
>
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Doremus resolved PLUTO-484.
---------------------------------
Resolution: Fixed
Applied fix to recently reported Exception in trunk in SVN rev 682097, 2.0-refactoring branch in SVN rev 682098, and in pluto 1.1.x branch in SVN rev 682100.
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 2.0.0, 2.0-refactoring, 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita Dubrovsky
> Assignee: Craig Doremus
> Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated PLUTO-484:
-------------------------------
Attachment: (was: P484-1.1.x-Rev652071.diff)
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita
> Fix For: 2.0.0, 1.1.6
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Doremus updated PLUTO-484:
--------------------------------
Fix Version/s: 2.0-refactoring
Affects Version/s: 2.0-refactoring
2.0.0
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 2.0.0, 2.0-refactoring, 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita Dubrovsky
> Assignee: Craig Doremus
> Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated PLUTO-484:
-------------------------------
Attachment: P484-1.1.x-Rev652071.diff
Patch created against 1.1.x branch at Rev652071
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PLUTO-484) PortletURLImpl.setSecure() throws
PortletSecurityException when PortletURLProvider.isSecureSupported()
returns true
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Doremus closed PLUTO-484.
-------------------------------
Resolution: Fixed
Applied patch to 1.1.x branch, trunk and pluto-2.0-spi-refactoring branch in SVN revs 662392, 662393 and 662396. Thanks Nikita.
> PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true
> -------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-484
> URL: https://issues.apache.org/jira/browse/PLUTO-484
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 1.1.5
> Environment: Tomcat 5.5.26
> Reporter: Nikita Dubrovsky
> Fix For: 2.0.0, 1.1.6
>
> Attachments: P484-1.1.x-Rev652071.diff
>
>
> The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
> The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:
> public void setSecure(boolean secure) throws PortletSecurityException {
> if(!secure) {
> return;
> }
> PortletURLProvider urlProvider = container
> .getRequiredContainerServices()
> .getPortalCallbackService()
> .getPortletURLProvider(servletRequest, internalPortletWindow);
> if(urlProvider.isSecureSupported()) {
> urlProvider.setSecure();
> } else {
> throw new PortletSecurityException("Secure URLs not supported.");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.