Re: [PR] [SPARK-49598][K8S] Support user-defined labels for OnDemand PVCs [spark]

["prathit06 (via GitHub)" <gi...@apache.org>]

prathit06 commented on PR #48079:
URL: https://github.com/apache/spark/pull/48079#issuecomment-2344273372

   > Thank you for making a PR, @prathit06 .
   > 
   > The proposed pattern `options.labels` is inconsistent from Apache Spark's way; `spark.kubernetes.driver.label.something=true` and `spark.kubernetes.executor.label.something=true`. Please follow the standard way.
   
   Thanks for the review @dongjoon-hyun , will work on the provided suggestion & update here once the PR is ready for review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org