You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Emmanuel Lécharny <el...@symas.com> on 2018/10/21 19:25:37 UTC

LDAP API JNDI operations

Hi !

I'm finishing up the Decorator removal, and I'm alsmost done (still have
to process the IntermediateResponse).

At this point, I'm facing an issue with a JNDI conversion function :

public javax.naming.ldap.ExtendedRequest toJndi( final ExtendedRequest
modelRequest ) throws EncoderException

The problem is that we have to convert an ExtendedRequest value to a
byte[], while we don't store anymore this value (what's the point of
doing so when we can find out which ext op has been called ?)

This is used by the StoredProcedure interceptor in the server, as SP are
still using the JNDI interface. Two things here :
- SP aren't working at the moment. There have been way too much water
running under the bridge
- If we want to revive SP, then it will have to use the LDAP API interface


So I strongly suggest we get rid of this method, if nobody objects.


Otherwise, and if we look a but further, we should probably get rid of
all the JNDI conversions methods, at least in the LDAP API v3.0


Thoughts ?

Re: LDAP API JNDI operations

Posted by Lucas Theisen <lu...@pastdev.com>.
I also agree.  From your description it definitely sounds like cruft.

On Mon, Oct 22, 2018, 4:38 AM Emmanuel Lécharny <el...@gmail.com> wrote:

>
>
> Le 22/10/2018 à 10:07, Radovan Semancik a écrit :
> > Hi,
> >
> > Perfectly OK with me. I do not really see any point in mixing JNDI and
> > Apache Directory API.
>
> FTR, it was there for purely historic reasons...
>
> The very first version (back in 2006) was based on the code we had in
> the server, and when it was started in 2003, having a JNDI interface was
> mandatory in order to make ApacheDS embedable.
>
> As soon as the API was spinned off, JNDI has lost its value as an
> interface, at least for us.
>
> Still, there are some remanent scares in the API code, typically the one
> I mentionned, as it's used by the server. Time to get rid of those !
>
> Thanks !
>
> --
> Emmanuel Lecharny
>
> Symas.com
> directory.apache.org
>
>

Re: LDAP API JNDI operations

Posted by Emmanuel Lécharny <el...@gmail.com>.

Le 22/10/2018 à 10:07, Radovan Semancik a écrit :
> Hi,
> 
> Perfectly OK with me. I do not really see any point in mixing JNDI and
> Apache Directory API.

FTR, it was there for purely historic reasons...

The very first version (back in 2006) was based on the code we had in
the server, and when it was started in 2003, having a JNDI interface was
mandatory in order to make ApacheDS embedable.

As soon as the API was spinned off, JNDI has lost its value as an
interface, at least for us.

Still, there are some remanent scares in the API code, typically the one
I mentionned, as it's used by the server. Time to get rid of those !

Thanks !

-- 
Emmanuel Lecharny

Symas.com
directory.apache.org


Re: LDAP API JNDI operations

Posted by Radovan Semancik <ra...@evolveum.com>.
Hi,

Perfectly OK with me. I do not really see any point in mixing JNDI and 
Apache Directory API.

-- 
Radovan Semancik
Software Architect
evolveum.com



On 10/21/18 21:25, Emmanuel Lécharny wrote:
> Hi !
>
> I'm finishing up the Decorator removal, and I'm alsmost done (still have
> to process the IntermediateResponse).
>
> At this point, I'm facing an issue with a JNDI conversion function :
>
> public javax.naming.ldap.ExtendedRequest toJndi( final ExtendedRequest
> modelRequest ) throws EncoderException
>
> The problem is that we have to convert an ExtendedRequest value to a
> byte[], while we don't store anymore this value (what's the point of
> doing so when we can find out which ext op has been called ?)
>
> This is used by the StoredProcedure interceptor in the server, as SP are
> still using the JNDI interface. Two things here :
> - SP aren't working at the moment. There have been way too much water
> running under the bridge
> - If we want to revive SP, then it will have to use the LDAP API interface
>
>
> So I strongly suggest we get rid of this method, if nobody objects.
>
>
> Otherwise, and if we look a but further, we should probably get rid of
> all the JNDI conversions methods, at least in the LDAP API v3.0
>
>
> Thoughts ?



Re: LDAP API JNDI operations

Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
On 10/21/18 9:25 PM, Emmanuel Lécharny wrote:
> Hi !
> 
> I'm finishing up the Decorator removal, and I'm alsmost done (still have
> to process the IntermediateResponse).
> 
> At this point, I'm facing an issue with a JNDI conversion function :
> 
> public javax.naming.ldap.ExtendedRequest toJndi( final ExtendedRequest
> modelRequest ) throws EncoderException
> 
> The problem is that we have to convert an ExtendedRequest value to a
> byte[], while we don't store anymore this value (what's the point of
> doing so when we can find out which ext op has been called ?)
> 
> This is used by the StoredProcedure interceptor in the server, as SP are
> still using the JNDI interface. Two things here :
> - SP aren't working at the moment. There have been way too much water
> running under the bridge
> - If we want to revive SP, then it will have to use the LDAP API interface
> 
> 
> So I strongly suggest we get rid of this method, if nobody objects.
> 
> 
> Otherwise, and if we look a but further, we should probably get rid of
> all the JNDI conversions methods, at least in the LDAP API v3.0

Yes, remove the JNDI layer if possible. Same we should do in Studio btw.