[GitHub] villebro commented on issue #5380: Add time grain blacklist and tests for validity

[GitBox <gi...@apache.org>]

villebro commented on issue #5380: Add time grain blacklist and tests for validity
URL: https://github.com/apache/incubator-superset/pull/5380#issuecomment-405942591
 
 
   Also added functionality to be able to add new custom time grains in `config.py` (`TIME_GRAIN_ADDONS` and `TIME_GRAIN_ADDON_FUNCTIONS`). This could be used to move some less used time grains out of db_engine_specs, while still allowing for end users to define their own custom time grains where needed.
   
   Question: in `config.py`, which would be preferable: using a blacklist to remove predefined options (e.g. `VIZ_TYPE_BLACKLIST`), or effectively defining a whitelist (e.g. `LANGUAGES`)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org