[GitHub] [netbeans] dbalek commented on a diff in pull request #4135: LSP4J library updated to version 0.13

[GitBox <gi...@apache.org>]

dbalek commented on code in PR #4135:
URL: https://github.com/apache/netbeans/pull/4135#discussion_r879126528


##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/breakpoints/NbBreakpointsRequestHandler.java:
##########
@@ -126,7 +126,9 @@ public CompletableFuture<Void> setExceptionBreakpoints(SetExceptionBreakpointsAr
         boolean notifyCaught = ArrayUtils.contains(filters, CAUGHT_EXCEPTION_FILTER_NAME);
         boolean notifyUncaught = ArrayUtils.contains(filters, UNCAUGHT_EXCEPTION_FILTER_NAME);
         context.getBreakpointManager().setExceptionBreakpoints(notifyCaught, notifyUncaught);
-        return CompletableFuture.completedFuture(null);
+        SetExceptionBreakpointsResponse response = new SetExceptionBreakpointsResponse();
+        // TODO: response.setBreakpoints(...);

Review Comment:
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists