You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/06/01 18:03:26 UTC

[kudu-CR] fix compile error when compiling column_predicate-test.cc

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3233

to look at the new patch set (#10).

Change subject: fix compile error when compiling column_predicate-test.cc
......................................................................

fix compile error when compiling column_predicate-test.cc

The test does not compile against boost 1.56. The error message is:

  gtest-printers.h:245: undefined reference to `std::basic_ostream<char,
  std::char_traits<char>>& boost::operator<< <char,std::char_traits<char>
  ,kudu::ColumnPredicate>>(std::basic_ostream<char,
  std::char_traits<char>>&, boost::optional<kudu::ColumnPredicate> const&)`

It appears to be https://svn.boost.org/trac/boost/ticket/10825, but
including optional_io.hpp in column_predicate.h (the purported workaround)
yields a different compile error:

  operator<<: cannot bind lvalue to 'std::basic_ostream<char>&&'

Rather than defining operator<< in ColumnPredicate, let's just modify the
ASSERTs in the test. I don't understand gtest macros well enough to know why
this helps, but I've verified that the modified test compiles and passes
when built against boost 1.56 and 1.58.

Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
---
M src/kudu/common/column_predicate-test.cc
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3233/10
-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang <zs...@gmail.com>