You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/02 18:06:25 UTC

[GitHub] [arrow] dianaclarke commented on a change in pull request #8312: ARROW-9941: [Python] Better string representation for extension types

dianaclarke commented on a change in pull request #8312:
URL: https://github.com/apache/arrow/pull/8312#discussion_r498972124



##########
File path: python/pyarrow/tests/test_extension_type.py
##########
@@ -95,6 +95,18 @@ def test_ext_type_basics():
     assert ty.extension_name == "arrow.py_extension_type"
 
 
+def test_ext_type_str():
+    ty = IntegerType()
+    assert str(ty) == "DataType(int64)"
+    cpp_expected = "extension<arrow.py_extension_type<int64>>"

Review comment:
       TODO:  this should be: `extension<arrow.py_extension_type<IntegerType>>`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org