You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by GitBox <gi...@apache.org> on 2019/04/08 10:37:13 UTC
[GitHub] [incubator-echarts] Ovilia opened a new pull request #10231: feat:
add toolbox text style support
Ovilia opened a new pull request #10231: feat: add toolbox text style support
URL: https://github.com/apache/incubator-echarts/pull/10231
#10202 Requested a more flexible toolbox label configuring method. This PR fulfills that requirement but the little triangle in the design of https://gitlab.com/gitlab-org/gitlab-ce/issues/57130 is not supported.
Requirement:
<img width="147" alt="屏幕快照 2019-04-08 18 21 46副本" src="https://user-images.githubusercontent.com/779050/55717732-8b154a80-5a2c-11e9-96cf-98730c63c4aa.png">
Example of what you can get from this PR:
<img width="147" alt="屏幕快照 2019-04-08 18 21 46" src="https://user-images.githubusercontent.com/779050/55717753-95cfdf80-5a2c-11e9-9600-7de6598ebe7c.png">
The text color, background color, border radius, text padding can all be configured.
But the small triangle is currently not supported, because we have to add new option entry for that and thus needs further discussion. @Jivanvl Please see if this meets your requirement.
---
In this PR, I added support for several options for `toolbox.emphasis.iconStyle`, namely:
- `textPosition`, `textFill`, `textAlign`: these options were supported but have no effect for settings in `toolbox.emphasis.iconStyle.xxx` due to a bug and they were fixed in this PR.
- `textBackgroundColor`, `textBorderRadius`, `textPadding`: these are newly supported options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org