You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Kantor <dk...@us.ibm.com> on 2016/05/03 22:26:46 UTC
Review Request 46905: ATLAS-667: Enforce lower bound when
disconnecting references during entity deletion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46905/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-667
https://issues.apache.org/jira/browse/ATLAS-667
Repository: atlas
Description
-------
ATLAS-667: Enforce lower bound on references when deleting entities. If the deletion candidate is the target of a reference with a non-zero lower bound, disallow the delete if disconnecting the reference would reduce the reference cardinality to zero.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5aaaa8147f59773c25064375f767adf6b7
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f99080047c6fe45b55ae0c5ad7c1ba600e2
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java 8d2961ef5f9bae5ff40b03a9c00d5c1c51bf384b
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 5c59c8a7be68987738b23168ba92843cf229d61d
server-api/src/main/java/org/apache/atlas/typesystem/exception/NullRequiredAttributeException.java PRE-CREATION
Diff: https://reviews.apache.org/r/46905/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 46905: ATLAS-667: Enforce lower bound when
disconnecting references during entity deletion
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46905/#review132559
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java (line 284)
<https://reviews.apache.org/r/46905/#comment196773>
the same case should be taken care of for maps?
- Suma Shivaprasad
On May 3, 2016, 8:26 p.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46905/
> -----------------------------------------------------------
>
> (Updated May 3, 2016, 8:26 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-667
> https://issues.apache.org/jira/browse/ATLAS-667
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-667: Enforce lower bound on references when deleting entities. If the deletion candidate is the target of a reference with a non-zero lower bound, disallow the delete if disconnecting the reference would reduce the reference cardinality to zero.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5aaaa8147f59773c25064375f767adf6b7
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f99080047c6fe45b55ae0c5ad7c1ba600e2
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java 8d2961ef5f9bae5ff40b03a9c00d5c1c51bf384b
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 5c59c8a7be68987738b23168ba92843cf229d61d
> server-api/src/main/java/org/apache/atlas/typesystem/exception/NullRequiredAttributeException.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46905/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 46905: ATLAS-667: Enforce lower bound when
disconnecting references during entity deletion
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46905/#review132979
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On May 11, 2016, 11:15 p.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46905/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 11:15 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-667
> https://issues.apache.org/jira/browse/ATLAS-667
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-667: Enforce lower bound on references when deleting entities. If the deletion candidate is the target of a reference with a non-zero lower bound, disallow the delete if disconnecting the reference would reduce the reference cardinality to zero.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5aaaa8147f59773c25064375f767adf6b7
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f99080047c6fe45b55ae0c5ad7c1ba600e2
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java 8d2961ef5f9bae5ff40b03a9c00d5c1c51bf384b
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 5c59c8a7be68987738b23168ba92843cf229d61d
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763c6f298df6b66d392e909bdbf5323fb06c
> server-api/src/main/java/org/apache/atlas/typesystem/exception/NullRequiredAttributeException.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab09049a4609d57dbd1cab3a716184ff52c
>
> Diff: https://reviews.apache.org/r/46905/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 46905: ATLAS-667: Enforce lower bound when
disconnecting references during entity deletion
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46905/
-----------------------------------------------------------
(Updated May 11, 2016, 11:15 p.m.)
Review request for atlas.
Changes
-------
Addressed Suma's review comment - handle required map attribute use case.
Bugs: ATLAS-667
https://issues.apache.org/jira/browse/ATLAS-667
Repository: atlas
Description
-------
ATLAS-667: Enforce lower bound on references when deleting entities. If the deletion candidate is the target of a reference with a non-zero lower bound, disallow the delete if disconnecting the reference would reduce the reference cardinality to zero.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5aaaa8147f59773c25064375f767adf6b7
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f99080047c6fe45b55ae0c5ad7c1ba600e2
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java 8d2961ef5f9bae5ff40b03a9c00d5c1c51bf384b
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 5c59c8a7be68987738b23168ba92843cf229d61d
server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763c6f298df6b66d392e909bdbf5323fb06c
server-api/src/main/java/org/apache/atlas/typesystem/exception/NullRequiredAttributeException.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab09049a4609d57dbd1cab3a716184ff52c
Diff: https://reviews.apache.org/r/46905/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor