You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/14 10:39:00 UTC
[GitHub] [skywalking] xu1009 opened a new issue #8433: [Feature] Support collect thread pool metrics
xu1009 opened a new issue #8433:
URL: https://github.com/apache/skywalking/issues/8433
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
thread pool monitor is important in web service, server container, like tomcat, undertow etc, monitor its worker pool is very import, every project needs implement it
### Use case
when use skywalking, we can config target class extends ThreadPoolExecutor, get thread pool metric, like coresize, maxsize, poolsize, queue size..., and send this metric to oap service every second, from ui, can see the metric
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015590609
Check K8s monitoring temple config. Or just put the metric name on UI setup mode page, and enter. It will tell you, it's a labeled value.
Don't use tag equal to split one metric into several.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015495499
you mean the agent report metric with same name and different tags by meter api ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015518143
yes, the oal config like this in this way
expSuffix: instance(['service'], ['instance'], Layer.GENERAL)
metricPrefix: instancesss
metricsRules:
- name: undertow_thread_pool_core_size
exp: thread_pool.tagEqual("pool_name", "undertow_worker_pool").tagEqual("metric_type", "core_pool_size")
- name: undertow_thread_pool_max_size
exp: thread_pool.tagEqual("pool_name", "undertow_worker_pool").tagEqual("metric_type", "max_pool_size")
- name: undertow_thread_pool_size
exp: thread_pool.tagEqual("pool_name", "undertow_worker_pool").tagEqual("metric_type", "pool_size")
- name: undertow_thread_pool_queue_size
exp: thread_pool.tagEqual("pool_name", "undertow_worker_pool").tagEqual("metric_type", "queue_size")
- name: undertow_thread_pool_active_count
exp: thread_pool.tagEqual("pool_name", "undertow_worker_pool").tagEqual("metric_type", "active_size")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] [Java] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016656871
it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015235248
> i do not get your mean, there are many kinds of thread pool, every type thread pool can have a ui component, all in one seems strange，and it is difficult to look
We don't have to set all thread pool metrics in one UI component. But `labeled value` could reduce the cost of the database resources. The way you are doing right now, is making one metric per database row. But labeled value could compress all types(queue size, pool size, max pool size) into one metric name.
```
undertow_thread_pool{pool_name="undertow_pool1",type="pool_size"} 10
undertow_thread_pool{pool_name="undertow_pool2",type="pool_size"} 15
undertow_thread_pool{pool_name="undertow_pool2",type="max_size"} 20
```
Then you just need one metric name on the UI, `undertow_thread_pool`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1014109036
instance_undertow_thread_pool_core_size = from(ServiceInstanceJVMThreadPool.corePoolSize).filter(threadPoolNameType == ThreadPoolNameType.UNDERTOW).longAvg();
instance_undertow_thread_pool_max_size = from(ServiceInstanceJVMThreadPool.maximumPoolSize).filter(threadPoolNameType == ThreadPoolNameType.UNDERTOW).longAvg();
instance_undertow_thread_pool_size = from(ServiceInstanceJVMThreadPool.poolSize).filter(threadPoolNameType == ThreadPoolNameType.UNDERTOW).longAvg();
instance_undertow_thread_pool_queue_size = from(ServiceInstanceJVMThreadPool.queueSize).filter(threadPoolNameType == ThreadPoolNameType.UNDERTOW).longAvg();
instance_undertow_thread_pool_active_count = from(ServiceInstanceJVMThreadPool.activeCount).filter(threadPoolNameType == ThreadPoolNameType.UNDERTOW).longAvg();
message ThreadPool {
ThreadPoolNameType type = 1;
int64 corePoolSize = 2;
int64 maximumPoolSize = 3;
int64 poolSize = 4;
int64 queueSize = 5;
int64 activeCount = 6;
}
enum ThreadPoolNameType {
UNDERTOW_WORKER_POOL = 0;
TOMCAT_WORKER_POOL = 1;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015189686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015944579
This is a labeled value metrics visualized as a chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mrproliu commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016167704
In the MAL, if you want to make it as labels metrics, need to add the aggregate function on the metric. In this case, it should be thread_pool.avg(['pool_name', 'metrx_type', 'service']).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015512766
Yes. And AFAIK the MAL could land this one metric name with different tags in the storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 removed a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 removed a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016152475
```json
{
"metricCase_":1,
"metric_":{
"name_":"thread_pool",
"labels_":[
{
"name_":"metric_type",
"value_":"max_pool_size",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
{
"name_":"pool_name",
"value_":"undertow_worker_pool",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
],
"value_":80.0,
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
"service_":"",
"serviceInstance_":"",
"timestamp_":0,
"memoizedIsInitialized":1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016156454
@wankai123 @mrproliu Could you take a look? I hope the final result keep `thread_pool` as metric name, and labels(undertow_worker_pool + max_pool_size) as the final label.
@xu1009 It is better you could use `H2` server mode to check the data, or ElasticSearch. Otherwise, it is hard for us to help this very detailed thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #8433: [Feature] [Java] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016913771
Cool, good to see this. Let's move on to the official PR/Review to take care of code details. Thank you so much for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015214246
I think we should use `labeled value`, which only requires one metric name in the MAL script. And UI's component title could be `Thread Pool`, which could add more pool relative metrics easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016060400
And please provide the data in the MeterServiceHandler. Then we could know what is going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1014442147
ok, i have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016151857
{"metricCase_":1,"metric_":{"name_":"thread_pool","labels_":[{"name_":"metric_type","value_":"active_size","memoizedIsInitialized":-1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0},{"name_":"pool_name","value_":"undertow_worker_pool","memoizedIsInitialized":-1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0}],"value_":0.0,"memoizedIsInitialized":-1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0},"service_":"Your_ApplicationName","serviceInstance_":"e33531aac85b4b93b8404b4f5f008fc8@192.168.255.10","timestamp_":1642576599799,"memoizedIsInitialized":1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016052740
yes, i config it in this way, but, it has no data in ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016060400
And please provide the data in the MeterReceiver. Then we could know what is going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016152475
{"metricCase_":1,"metric_":{"name_":"thread_pool","labels_":[{"name_":"metric_type","value_":"max_pool_size","memoizedIsInitialized":-1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0},{"name_":"pool_name","value_":"undertow_worker_pool","memoizedIsInitialized":-1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0}],"value_":80.0,"memoizedIsInitialized":-1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0},"service_":"","serviceInstance_":"","timestamp_":0,"memoizedIsInitialized":1,"unknownFields":{"fields":{}},"memoizedSize":-1,"memoizedHashCode":0}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1014433537
For agent side, it is very similar to agent tracing plugin. Just calling different core APIs. Check this.
https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015518143
yes, the oal config like this in this way，same metric name with tag filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015229172
i do not get your mean, there are many kinds of thread pool, every type thread pool can have a ui component, all in one seems strange，and it is difficult to look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1014114078
This kind of filter function is very hard coded, and it has to set for all kinds of pools, which is not flexible, and have to set a lot of UI components to list all possibilities.
I am thinking whether we should treat this as a logic endpoint? And metrics reporting through meter API rather than JVM and OAL analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] [Java] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016570318
@xu1009 Any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] [Java] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1024865712
@xu1009 Are you going to add more meter plugins for thread pools?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015186603
It is good to know. Could you post the metric sample here? To make the further review easier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] [Java] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016913771
Cool, good to see this. Let's move on to the official PR/Review to take care of code details. Thank you so much for you patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015518143
yes, the oal config like this in this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1013040095
Could you share what do the OAP and UI look like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1014439424
At the backend, you just need to learn meter receiver and MAL
1. https://skywalking.apache.org/docs/main/latest/en/setup/backend/backend-meter/#manual-meter-api
2. Meter design, https://skywalking.apache.org/docs/main/latest/en/concepts-and-designs/meter/
3. MAL, https://skywalking.apache.org/docs/main/latest/en/concepts-and-designs/mal/
And learn fron slueth MAL setup
1. https://skywalking.apache.org/docs/main/latest/en/setup/backend/spring-sleuth-setup/
2. Configuration file example, https://github.com/apache/skywalking/blob/fc27f766c5da0f4165152025a6ba4080d034d1fc/oap-server/server-starter/src/main/resources/meter-analyzer-config/spring-sleuth.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016241894
no data display in ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016152475
```json
{
"metricCase_":1,
"metric_":{
"name_":"thread_pool",
"labels_":[
{
"name_":"metric_type",
"value_":"max_pool_size",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
{
"name_":"pool_name",
"value_":"undertow_worker_pool",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
],
"value_":80.0,
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
"service_":"",
"serviceInstance_":"",
"timestamp_":0,
"memoizedIsInitialized":1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016148766
Could you put this in JSON format? And print it in the console, and provide us the rawdata? This debug screenshot is hard for us to know the details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016215328
The data looks good, what do you mean `not ok`?
This is my understanding of the data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #8433: [Feature] [Java] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #8433:
URL: https://github.com/apache/skywalking/issues/8433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1014428323
emm, the agent plugin and oap server is easy to add new thread pool, the problem is how to display it in ui, i am not familiar with what you say, this has some demo in skywalking project，or, we can make basic plugin to collect metirc and save it, every one can customizing their dashboard ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015231343
i think we can provide some base thread pool metric collect, like undertow, tomcat, other user can easy to add based on this way, and they can custom their own ui component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015523043
This config still could make the metrics into different metric name. I prefer we could do
```
metricsRules:
- name: java_thread_pool
exp: java_thread_pool
```
If you want to separate pools of Java, you could use `undertow_thread_pool`. And types of `metric_type` is going to be available on the UI automatically as labels.
Coud you try this? @wankai123 could help if you face any issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016055684
Could you check what does the metric look like in the database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016212886
it is not ok, the above image is data in database
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016052740
yes, i config it in this way, but, it has no data in ui, from the agent log, i can see meter report data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1013019521
now, in my projeject, agent core has a model contains pool name and thead threadPoolExecutor instance, the agent plugin set the thread pool name and instance to it on constructor, and the core get message from the model, and send metrics to oap service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1013015979
Then we need a way to build a labels(pool name) metric for connection pool. What do you want to build?
Could you provide more details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016144701
<img width="1244" alt="企业微信截图_f3a61c2b-75c1-4388-b698-5050d9f59509" src="https://user-images.githubusercontent.com/22722907/150081024-af46573e-d93b-43a4-a654-c780cd6ff128.png">
this is the data from MeterServiceHandler， the database is h2, i do not have tool to look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015185532
i have tried, it is ok，plugin can give the threadPoolExecutor instance, and agent core build thread pool metrics, and send it to backend by meter api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1015585977
i try, it not work, could you give some demo with ui template and oal config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1013040095
Could you share what do the OAL script, the new part of proto, and UI look like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016244447
Do you check the instance name(entity name in the table) and time bucket?
And, you could debug `MetricsQuery#readLabeledMetricsValues` to see what is going on. The logic is also not hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016151857
```json
{
"metricCase_":1,
"metric_":{
"name_":"thread_pool",
"labels_":[
{
"name_":"metric_type",
"value_":"active_size",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
{
"name_":"pool_name",
"value_":"undertow_worker_pool",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
],
"value_":0.0,
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
"service_":"Your_ApplicationName",
"serviceInstance_":"e33531aac85b4b93b8404b4f5f008fc8@192.168.255.10",
"timestamp_":1642576599799,
"memoizedIsInitialized":1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
```
The second in the same streaming.
```json
{
"metricCase_":1,
"metric_":{
"name_":"thread_pool",
"labels_":[
{
"name_":"metric_type",
"value_":"max_pool_size",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
{
"name_":"pool_name",
"value_":"undertow_worker_pool",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
],
"value_":80.0,
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
"service_":"",
"serviceInstance_":"",
"timestamp_":0,
"memoizedIsInitialized":1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 edited a comment on issue #8433: [Feature] Support collect thread pool metrics
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on issue #8433:
URL: https://github.com/apache/skywalking/issues/8433#issuecomment-1016151857
```json
{
"metricCase_":1,
"metric_":{
"name_":"thread_pool",
"labels_":[
{
"name_":"metric_type",
"value_":"active_size",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
{
"name_":"pool_name",
"value_":"undertow_worker_pool",
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
],
"value_":0.0,
"memoizedIsInitialized":-1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
},
"service_":"Your_ApplicationName",
"serviceInstance_":"e33531aac85b4b93b8404b4f5f008fc8@192.168.255.10",
"timestamp_":1642576599799,
"memoizedIsInitialized":1,
"unknownFields":{
"fields":{
}
},
"memoizedSize":-1,
"memoizedHashCode":0
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org