[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #176: chore(extensions/nanoarrow_ipc): Test files from the arrow-testing repo

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #176:
URL: https://github.com/apache/arrow-nanoarrow/pull/176#discussion_r1153519992


##########
src/nanoarrow/array.c:
##########
@@ -910,10 +910,6 @@ ArrowErrorCode ArrowArrayViewValidateFull(struct ArrowArrayView* array_view,
                                           struct ArrowError* error) {
   for (int i = 0; i < 3; i++) {
     switch (array_view->layout.buffer_type[i]) {
-      case NANOARROW_BUFFER_TYPE_UNION_OFFSET:

Review Comment:
   Hmm, dense union offsets don't have to be increasing?



##########
src/nanoarrow/array.c:
##########
@@ -910,10 +910,6 @@ ArrowErrorCode ArrowArrayViewValidateFull(struct ArrowArrayView* array_view,
                                           struct ArrowError* error) {
   for (int i = 0; i < 3; i++) {
     switch (array_view->layout.buffer_type[i]) {
-      case NANOARROW_BUFFER_TYPE_UNION_OFFSET:

Review Comment:
   Ah, "The respective offsets for each child value array must be in order / increasing." So if we want to validate this it'll be trickier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org