You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/12 04:32:11 UTC

[GitHub] [spark] maropu commented on pull request #29983: [SPARK-13860][SQL] Change CentralMomentAgg to return null instead of Double.NaN when divideByZero

maropu commented on pull request #29983:
URL: https://github.com/apache/spark/pull/29983#issuecomment-706852592


   > found two more place return Double.NaN with DivideByZero case. should I update these as well??
   and change ConfigName to spark.sql.legacy.divideByZeroEvaluation ??
   
   Or, `spark.sql.legacy.centralMomentAndCovarianceAgg`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org