You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Archana kumari <ar...@gmail.com> on 2014/03/17 05:41:05 UTC
Review Request 19271: Fixed a TODO in linux/cgroups.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19271/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Fixed a TODO in linux/cgroups.cpp
Diffs
-----
src/linux/cgroups.cpp 6f95376
src/linux/fs.hpp 1d86dd0
Diff: https://reviews.apache.org/r/19271/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19271: Fixed a TODO in linux/cgroups.cpp
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19271/#review37338
-----------------------------------------------------------
Bad patch!
Reviews applied: [19271]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
linux/fs.cpp:37:6: error: 'MountTable' has not been declared
linux/fs.cpp:37:62: error: non-member function 'bool mesos::internal::fs::hasOption(const string&)' cannot have cv-qualifier
linux/fs.cpp: In function 'bool mesos::internal::fs::hasOption(const string&)':
linux/fs.cpp:40:41: error: 'fsname' was not declared in this scope
linux/fs.cpp:41:38: error: 'dir' was not declared in this scope
linux/fs.cpp:42:39: error: 'type' was not declared in this scope
linux/fs.cpp:43:39: error: 'opts' was not declared in this scope
linux/fs.cpp:44:21: error: 'freq' was not declared in this scope
linux/fs.cpp:45:23: error: 'passno' was not declared in this scope
linux/fs.cpp: At global scope:
linux/fs.cpp:50:5: error: 'MountTable' was not declared in this scope
linux/fs.cpp:50:5: note: suggested alternative:
./linux/fs.hpp:39:8: note: 'internal::fs::MountTable'
linux/fs.cpp:50:15: error: template argument 1 is invalid
linux/fs.cpp:50:17: error: 'MountTable' has not been declared
linux/fs.cpp: In function 'int mesos::internal::fs::read(const string&)':
linux/fs.cpp:52:3: error: 'MountTable' was not declared in this scope
linux/fs.cpp:52:3: note: suggested alternative:
./linux/fs.hpp:39:8: note: 'internal::fs::MountTable'
linux/fs.cpp:52:14: error: expected ';' before 'table'
linux/fs.cpp:56:49: error: cannot convert 'Error' to 'int' in return
linux/fs.cpp:71:5: error: 'MountTable' is not a class, namespace, or enumeration
linux/fs.cpp:71:23: error: expected ';' before 'entry'
linux/fs.cpp:77:5: error: 'table' was not declared in this scope
linux/fs.cpp:77:29: error: 'entry' was not declared in this scope
linux/fs.cpp:105:10: error: 'table' was not declared in this scope
linux/fs.cpp: At global scope:
linux/fs.cpp:109:5: error: 'FileSystemTable' was not declared in this scope
linux/fs.cpp:109:5: note: suggested alternative:
./linux/fs.hpp:82:8: note: 'internal::fs::FileSystemTable'
linux/fs.cpp:109:20: error: template argument 1 is invalid
linux/fs.cpp:109:22: error: 'FileSystemTable' has not been declared
linux/fs.cpp: In function 'int mesos::internal::fs::read()':
linux/fs.cpp:115:3: error: 'FileSystemTable' was not declared in this scope
linux/fs.cpp:115:3: note: suggested alternative:
./linux/fs.hpp:82:8: note: 'internal::fs::FileSystemTable'
linux/fs.cpp:115:19: error: expected ';' before 'table'
linux/fs.cpp:123:54: error: cannot convert 'Error' to 'int' in return
linux/fs.cpp:132:7: error: 'FileSystemTable' is not a class, namespace, or enumeration
linux/fs.cpp:132:30: error: expected ';' before 'entry'
linux/fs.cpp:141:7: error: 'table' was not declared in this scope
linux/fs.cpp:141:31: error: 'entry' was not declared in this scope
linux/fs.cpp:147:10: error: 'table' was not declared in this scope
linux/fs.cpp:148:1: error: control reaches end of non-void function [-Werror=return-type]
linux/fs.cpp: In function 'int mesos::internal::fs::read(const string&)':
linux/fs.cpp:106:1: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors
make[2]: *** [linux/libmesos_no_3rdparty_la-fs.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 17, 2014, 4:41 a.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19271/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 4:41 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO in linux/cgroups.cpp
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 6f95376
> src/linux/fs.hpp 1d86dd0
>
> Diff: https://reviews.apache.org/r/19271/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>