You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/04 01:09:40 UTC
[GitHub] [incubator-hudi] XuQianJin-Stars opened a new pull request #1370:
[HUDI-653] Add JMX Report Config to Doc
XuQianJin-Stars opened a new pull request #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
Add JMX Report Config to doc
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1370:
[HUDI-653] Add JMX Report Config to Doc
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on issue #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370#issuecomment-601152532
> @XuQianJin-Stars Would you please only update the docs under _docs and please not update the docs under 0.5.0/0.5.1. Thanks.
well，Let me change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf merged pull request #1370: [HUDI-653] Add
JMX Report Config to Doc
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1370: [HUDI-653] Add JMX Report Config to Doc
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370#discussion_r387418288
##########
File path: docs/_docs/0.5.0/2_4_configurations.md
##########
@@ -391,29 +391,65 @@ Property: `hoodie.compaction.payload.class` <br/>
### Metrics configs
Review comment:
if you dohn't mind, lets add a link to this section from this page.. http://hudi.apache.org/docs/deployment.html#monitoring ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] XuQianJin-Stars commented on a change in pull
request #1370: [HUDI-653] Add JMX Report Config to Doc
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370#discussion_r387489800
##########
File path: docs/_docs/0.5.0/2_4_configurations.md
##########
@@ -391,29 +391,65 @@ Property: `hoodie.compaction.payload.class` <br/>
### Metrics configs
Review comment:
> if you dohn't mind, lets add a link to this section from this page.. http://hudi.apache.org/docs/deployment.html#monitoring ?
well, let me change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on a change in pull request #1370:
[HUDI-653] Add JMX Report Config to Doc
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370#discussion_r388226015
##########
File path: docs/_docs/0.5.0/2_4_configurations.md
##########
@@ -391,29 +391,65 @@ Property: `hoodie.compaction.payload.class` <br/>
### Metrics configs
Review comment:
did it update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1370: [HUDI-653] Add JMX
Report Config to Doc
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370#issuecomment-601144978
@XuQianJin-Stars Would you please only update the docs under _docs and please not update the docs under 0.5.0/0.5.1. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1370: [HUDI-653] Add JMX Report Config to Doc
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1370: [HUDI-653] Add JMX Report Config to Doc
URL: https://github.com/apache/incubator-hudi/pull/1370#discussion_r387418024
##########
File path: docs/_docs/0.5.0/2_4_configurations.cn.md
##########
@@ -426,29 +426,65 @@ Hudi提供了一个选项，可以通过将对该分区中的插入作为对现
### 指标配置
-能够将Hudi指标报告给graphite。
+配置Hudi指标报告。
[withMetricsConfig](#withMetricsConfig) (HoodieMetricsConfig) <br/>
<span style="color:grey">Hudi会发布有关每次提交、清理、回滚等的指标。</span>
-#### on(metricsOn = true) {#on}
+#### GRAPHITE
+
+Parameters:
+
+- host - 要连接的 graphite 主机, 默认是 localhost
Review comment:
lets stick to the existing conventions for documenting configs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services