You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2024/09/14 08:02:13 UTC
[PR] fix(install/docker): install zstd for building superset-frontend in containerized env [superset]
hainenber opened a new pull request, #30279:
URL: https://github.com/apache/superset/pull/30279
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(install/docker): install zstd for building superset-frontend in containerized environment
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #30206
It turns out that building `superset-node` in development's Docker Compose file [doesn't use image baked with `zstd`](https://github.com/apache/superset/blob/master/docker-compose.yml#L151-L152) and so we have to install it manually in the bootstrap script.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(install/docker): use zstd-baked image for building superset-frontend in containerized env [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #30279:
URL: https://github.com/apache/superset/pull/30279#issuecomment-2351368242
> Hey, I have an alternate fix as bycatch as part of #30274. I think it's the proper solution, where docker-compose should be using the `superset-node` layer which insures more compatibility between the build process when building layers with the docker-compose environment.
>
> It would be great to factor it out of my PR (as opposed to coupling it to the unrelated Slack avatar stuff). Feel free to copy/paste the solution from my PR here and I'll approve and merge.
Copy-pasted. The issue is still resolved after your alternate fix! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(install/docker): install zstd for building superset-frontend in containerized env [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #30279:
URL: https://github.com/apache/superset/pull/30279#issuecomment-2351083728
Hey, I have an alternate fix as bycatch as part of https://github.com/apache/superset/pull/30274. I think it's the proper solution, where docker-compose should be using the `superset-node` layer which insures more compatibility between the build process when building layers with the docker-compose environment.
It would be great to factor it out of my PR (as opposed to coupling it to the unrelated Slack avatar stuff). Feel free to copy/paste the solution from my PR here and I'll approve and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(install/docker): use zstd-baked image for building superset-frontend in containerized env [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #30279:
URL: https://github.com/apache/superset/pull/30279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org