svn commit: r1697951 - in /commons/proper/bcel/trunk: pom.xml src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java

[se...@apache.org]

Author: sebb
Date: Wed Aug 26 14:52:09 2015
New Revision: 1697951

URL: http://svn.apache.org/r1697951
Log:
BCEL-258 No tests to check the output of dump methods
Added (optional) test to check the dump methods in the classfile package

Added:
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java   (with props)
Modified:
    commons/proper/bcel/trunk/pom.xml

Modified: commons/proper/bcel/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/pom.xml?rev=1697951&r1=1697950&r2=1697951&view=diff
==============================================================================
--- commons/proper/bcel/trunk/pom.xml (original)
+++ commons/proper/bcel/trunk/pom.xml Wed Aug 26 14:52:09 2015
@@ -209,19 +209,21 @@
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
-        <systemProperties>
-          <property>
-             <!-- Suppress the stats, but keep the test as it exercises the code -->
-             <name>PerformanceTest.report</name>
-             <value>false</value>
-          </property>
-        </systemProperties>
+          <systemProperties>
+            <property>
+               <!-- Suppress the stats, but keep the test as it exercises the code -->
+               <name>PerformanceTest.report</name>
+               <value>false</value>
+            </property>
+          </systemProperties>
           <includes>
             <include>**/*TestCase.java</include>
             <include>**/PerformanceTest.java</include>
           </includes>
           <excludes>
             <exclude>**/Abstract*</exclude>
+            <!-- Takes rather a long time (especially rt.jar) ; only needs to be done occasionally -->
+            <exclude>**/JDKClassDumpTestCase.java</exclude>
           </excludes>
         </configuration>
       </plugin>

Added: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java?rev=1697951&view=auto
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java (added)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java Wed Aug 26 14:52:09 2015
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.bcel6.classfile;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.File;
+import java.io.FileFilter;
+import java.io.InputStream;
+import java.util.Enumeration;
+import java.util.jar.JarEntry;
+import java.util.jar.JarFile;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Test that dump() methods work on the JDK classes
+ */
+public class JDKClassDumpTestCase {
+
+    @Test
+    public void testPerformance() throws Exception {
+        File javaLib = new File(System.getProperty("java.home") + "/lib");
+        javaLib.listFiles(new FileFilter() {
+
+            @Override
+            public boolean accept(File file) {
+                if(file.getName().endsWith(".jar")) {
+                    try {
+                        testJar(file);
+                    } catch (Exception e) {
+                        Assert.fail(e.getMessage());
+                    }
+                }
+                return false;
+            }
+        });
+    }
+
+
+    private void testJar(File file) throws Exception {
+        System.out.println("parsing " + file);
+        JarFile jar = new JarFile(file);
+        Enumeration<JarEntry> en = jar.entries();
+
+        while (en.hasMoreElements()) {
+            JarEntry e = en.nextElement();
+            final String name = e.getName();
+            if (name.endsWith(".class")) {
+//                System.out.println("parsing " + name);
+                InputStream in = jar.getInputStream(e);
+                ClassParser parser = new ClassParser(in, name);
+                JavaClass jc = parser.parse();
+                compare(jc, jar.getInputStream(e), name);
+            }
+        }
+        jar.close();
+    }
+
+    private void compare(JavaClass jc, InputStream inputStream, String name) throws Exception {
+        final ByteArrayOutputStream baos = new ByteArrayOutputStream();
+        DataOutputStream dos = new DataOutputStream(baos);
+        jc.dump(dos);
+        dos.close();
+        DataInputStream src = new DataInputStream(inputStream);
+        int i=0;
+        for(int out : baos.toByteArray()) {
+            int in = src.read();
+            assertEquals(name + ": Mismatch at "+i, in, out&0xFF);
+            i++;
+        }
+        src.close();
+    }
+
+
+}

Propchange: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/classfile/JDKClassDumpTestCase.java
------------------------------------------------------------------------------
    svn:eol-style = native