You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Ronny Völker (JIRA)" <ji...@apache.org> on 2006/11/08 16:12:52 UTC
[jira] Commented: (TORQUE-63) Wrong caching of method calls with
more than three arguments in MethodResultCache
[ http://issues.apache.org/jira/browse/TORQUE-63?page=comments#action_12448159 ]
Ronny Völker commented on TORQUE-63:
------------------------------------
the following patch should fix it:
Index: src/java/org/apache/torque/manager/MethodCacheKey.java
===================================================================
--- src/java/org/apache/torque/manager/MethodCacheKey.java (revision 471460)
+++ src/java/org/apache/torque/manager/MethodCacheKey.java (working copy)
@@ -167,7 +167,7 @@
this.arg2 = keys[3];
if (n > 2)
{
- this.arg2 = keys[4];
+ this.arg3 = keys[4];
if (n > 3)
{
this.moreThanThree = keys;
> Wrong caching of method calls with more than three arguments in MethodResultCache
> ---------------------------------------------------------------------------------
>
> Key: TORQUE-63
> URL: http://issues.apache.org/jira/browse/TORQUE-63
> Project: Torque
> Issue Type: Bug
> Components: Runtime
> Affects Versions: 3.2, 3.1.1, 3.1, 3.0
> Reporter: Ronny Völker
> Fix For: 3.2.1, 4.0
>
>
> When caching a method call with more than three arguments using MethodResultCache#put(Object value, Serializable keys), the 2nd argument is ignored, because it is overwritten by the 3rd argument in MethodCacheKey#init(Serializable keys).
> That means that two method calls which are only different in their 2nd argument are cached in the same slot.
> When the second call is cached, the first call is overwritten.
> When the cache is later queried for the first call, the result of the second call is returned.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org