You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/01/18 15:41:13 UTC
[GitHub] [incubator-eventmesh] jinrongluo opened a new pull request #723: [Issue #417] update Grpc Message Model name to SimpleMessage
jinrongluo opened a new pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723
Fixes ISSUE #417
### Motivation
update Grpc Message Model name to SimpleMessage
### Modifications
- sync the commits from master branch
- update Grpc Message Model name to SimpleMessage
- update the Grpc documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 edited a comment on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 edited a comment on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1029799145
I run the `AsyncPublishInstance` and `EventmeshAsyncSubscribe` under the `grpc` module, got following error:
- Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.
After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ?
@jinrongluo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1033662377
Hi, @jinrongluo if I run the `AsyncPublishInstance` first, then run the `EventMeshAsyncSubscribe` this may reproduce the error mentioned above, and for server side got the error below:
- **Receive error from client: CANCELLED: cancelled before receiving half close**
- **StreamObserver Error onCompleted. CANCELLED: call already cancelled**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1029422992
> please fix the conflicts thanks. @jinrongluo
Merge conflict is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r787880261
##########
File path: docs/cn/instructions/eventmesh-runtime-protocol.md
##########
@@ -290,7 +290,7 @@ message RequestHeader {
string protocolDesc = 12;
}
-message EventMeshMessage {
+message SimpleMessage {
Review comment:
in my opinion, the naming need to be consistent across the protocol.
If we choose to use MessageRequest, then we have to add "Request" to the other message names as well: "BatchMessageRequest", "SubscriptionRequest", "HeartBeatRequest".
But I also think adding the word "Request" is a little bit redundant, because this is already a GRPC request message in nature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r797241077
##########
File path: eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/CloudEventsSubscribeReply.java
##########
@@ -0,0 +1,69 @@
+package org.apache.eventmesh.grpc.sub;
+
+import io.cloudevents.CloudEvent;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.eventmesh.client.grpc.config.EventMeshGrpcClientConfig;
+import org.apache.eventmesh.client.grpc.consumer.EventMeshGrpcConsumer;
+import org.apache.eventmesh.client.grpc.consumer.ReceiveMsgHook;
+import org.apache.eventmesh.client.tcp.common.EventMeshCommon;
+import org.apache.eventmesh.common.protocol.SubscriptionItem;
+import org.apache.eventmesh.common.protocol.SubscriptionMode;
+import org.apache.eventmesh.common.protocol.SubscriptionType;
+import org.apache.eventmesh.util.Utils;
+
+import java.util.Collections;
+import java.util.Optional;
+import java.util.Properties;
+
+@Slf4j
+public class CloudEventsSubscribeReply implements ReceiveMsgHook<CloudEvent> {
+
+ public static CloudEventsSubscribeReply handler = new CloudEventsSubscribeReply();
+
+ public static void main(String[] args) throws InterruptedException {
+ Properties properties = Utils.readPropertiesFile("application.properties");
+ final String eventMeshIp = properties.getProperty("eventmesh.ip");
+ final String eventMeshGrpcPort = properties.getProperty("eventmesh.grpc.port");
+
+ final String topic = "TEST-TOPIC-GRPC-RR";
+
+ EventMeshGrpcClientConfig eventMeshClientConfig = EventMeshGrpcClientConfig.builder()
+ .serverAddr(eventMeshIp)
+ .serverPort(Integer.parseInt(eventMeshGrpcPort))
+ .consumerGroup("EventMeshTest-consumerGroup")
+ .env("env").idc("idc")
+ .sys("1234").build();
+
+ SubscriptionItem subscriptionItem = new SubscriptionItem();
+ subscriptionItem.setTopic(topic);
+ subscriptionItem.setMode(SubscriptionMode.CLUSTERING);
+ subscriptionItem.setType(SubscriptionType.ASYNC);
Review comment:
this should be `subscriptionItem.setType(SubscriptionType.SYNC)`, because this is request-reply mode.
##########
File path: eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/EventmeshSubscribeReply.java
##########
@@ -0,0 +1,68 @@
+package org.apache.eventmesh.grpc.sub;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.eventmesh.client.grpc.config.EventMeshGrpcClientConfig;
+import org.apache.eventmesh.client.grpc.consumer.EventMeshGrpcConsumer;
+import org.apache.eventmesh.client.grpc.consumer.ReceiveMsgHook;
+import org.apache.eventmesh.client.tcp.common.EventMeshCommon;
+import org.apache.eventmesh.common.EventMeshMessage;
+import org.apache.eventmesh.common.protocol.SubscriptionItem;
+import org.apache.eventmesh.common.protocol.SubscriptionMode;
+import org.apache.eventmesh.common.protocol.SubscriptionType;
+import org.apache.eventmesh.util.Utils;
+
+import java.util.Collections;
+import java.util.Optional;
+import java.util.Properties;
+
+@Slf4j
+public class EventmeshSubscribeReply implements ReceiveMsgHook<EventMeshMessage> {
+
+ public static EventmeshSubscribeReply handler = new EventmeshSubscribeReply();
+
+ public static void main(String[] args) throws InterruptedException {
+ Properties properties = Utils.readPropertiesFile("application.properties");
+ final String eventMeshIp = properties.getProperty("eventmesh.ip");
+ final String eventMeshGrpcPort = properties.getProperty("eventmesh.grpc.port");
+
+ final String topic = "TEST-TOPIC-GRPC-RR";
+
+ EventMeshGrpcClientConfig eventMeshClientConfig = EventMeshGrpcClientConfig.builder()
+ .serverAddr(eventMeshIp)
+ .serverPort(Integer.parseInt(eventMeshGrpcPort))
+ .consumerGroup("EventMeshTest-consumerGroup")
+ .env("env").idc("idc")
+ .sys("1234").build();
+
+ SubscriptionItem subscriptionItem = new SubscriptionItem();
+ subscriptionItem.setTopic(topic);
+ subscriptionItem.setMode(SubscriptionMode.CLUSTERING);
+ subscriptionItem.setType(SubscriptionType.ASYNC);
Review comment:
this should be `subscriptionItem.setType(SubscriptionType.SYNC)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r790093986
##########
File path: docs/cn/instructions/eventmesh-runtime-protocol.md
##########
@@ -290,7 +290,7 @@ message RequestHeader {
string protocolDesc = 12;
}
-message EventMeshMessage {
+message SimpleMessage {
Review comment:
Ok, I just worried that someone might mistakenly think this is a message type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1030043134
>
Hi @xwm1992 I am not able to reproduce this error in my development environment. How are you running this test?
Please make sure you use the right Publisher and Subscriber as shown below. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 edited a comment on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 edited a comment on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1033662377
Hi, @jinrongluo if I run the `AsyncPublishInstance` first, then run the `EventMeshAsyncSubscribe` this may reproduce the error mentioned above, and for server side got the error below:
- **Receive error from client: CANCELLED: cancelled before receiving half close**
- **StreamObserver Error onCompleted. CANCELLED: call already cancelled**
- **(Http2ConnectionHandler.java:911) - [id: 0xdffacbb2, L:/127.0.0.1:10205 - R:/127.0.0.1:51069] Sent GOAWAY: lastStreamId '3', errorCode '2', debugData 'Stream 3 sent too many headers EOS: false'. Forcing shutdown of the connection.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1029424626
@xwm1992 I have completed the development and testing of this PR. Please go ahead and run more testing at your end. Thanks. for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r790439369
##########
File path: docs/en/instructions/eventmesh-sdk-java-quickstart.md
##########
@@ -70,3 +70,55 @@ Run the main method of org.apache.eventmesh.http.demo.sub.SpringBootDemoApplicat
Run the main method of org.apache.eventmesh.http.demo.pub.eventmeshmessage.AsyncPublishInstance
```
+### 3. GRPC DEMO
+
+> As to GRPC, eventmesh-sdk-java implements the Google gRPC and Google Protocol Buffers. It can send events to eventmesh-runtime asynchronously
+> and synchronously (using request-reply). It can also subscribe to the events using webhook subscriber and stream subscriber.
+> Apache CloudEvents protocol is also supported in the demo.
Review comment:
CloudEvents is CNCF spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling merged pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1027544420
If all the changes has been done, you can leave a notification and I'll do the whole test again thanks. @jinrongluo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1028191856
>
hi @xwm1992 I still need to run more testing in myself. I will let you know when I done. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1029799145
I run the `AsyncPublishInstance` and `EventmeshAsyncSubscribe` under the `grpc` module, got following error:
- Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.
After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r791818624
##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart-with-docker.md
##########
@@ -78,7 +78,7 @@ sudo vi eventmesh.properties
|----------------------------|-------|----------------------------|
| eventMesh.server.http.port | 10105 | EventMesh http server port |
| eventMesh.server.tcp.port | 10000 | EventMesh tcp server port |
-
+| eventMesh.server.grpc.port | 10205 | EventMesh grpc server port |
### 配置 rocketmq-client.properties
Review comment:
I didn't change any rocketmq related information. it is in the original readme document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1027537553
please fix the conflicts thanks. @jinrongluo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r787662462
##########
File path: docs/cn/instructions/eventmesh-runtime-protocol.md
##########
@@ -290,7 +290,7 @@ message RequestHeader {
string protocolDesc = 12;
}
-message EventMeshMessage {
+message SimpleMessage {
Review comment:
What about using `MessageRequest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r791818624
##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart-with-docker.md
##########
@@ -78,7 +78,7 @@ sudo vi eventmesh.properties
|----------------------------|-------|----------------------------|
| eventMesh.server.http.port | 10105 | EventMesh http server port |
| eventMesh.server.tcp.port | 10000 | EventMesh tcp server port |
-
+| eventMesh.server.grpc.port | 10205 | EventMesh grpc server port |
### 配置 rocketmq-client.properties
Review comment:
I didn't change any rocketmq related information. it is in the original readme document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on a change in pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#discussion_r790428932
##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart-with-docker.md
##########
@@ -78,7 +78,7 @@ sudo vi eventmesh.properties
|----------------------------|-------|----------------------------|
| eventMesh.server.http.port | 10105 | EventMesh http server port |
| eventMesh.server.tcp.port | 10000 | EventMesh tcp server port |
-
+| eventMesh.server.grpc.port | 10205 | EventMesh grpc server port |
### 配置 rocketmq-client.properties
Review comment:
Remove rocketmq...
##########
File path: docs/cn/instructions/eventmesh-sdk-java-quickstart.md
##########
@@ -70,5 +70,54 @@ TCP 和 HTTP 示例都在**eventmesh-example**模块下
运行org.apache.eventmesh.http.demo.pub.eventmeshmessage.AsyncPublishInstance的主要方法
```
+### 3. GRPC 演示
+> 对于 GRPC, eventmesh-sdk-java 实现了 Google gRPC 和 Google Protocol Buffers 协议. 它能异步和同步发送事件到 eventmesh-runtime.
Review comment:
No need to mention Google, gRPC and Protocol Buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo edited a comment on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo edited a comment on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1034198696
> I run the `AsyncPublishInstance` and `EventmeshAsyncSubscribe` under the `grpc` module, got following error:
>
> * Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.
> 
>
> After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ? 
>
> this error is not inevitable, please take a look, thanks. @jinrongluo
Thanks @xwm1992 The root cause of this issue is that Grpc StreamObserver is not thread safe. The Java doc is here:
https://grpc.github.io/grpc-java/javadoc/io/grpc/stub/StreamObserver.html
```
Since individual StreamObservers are not thread-safe, if multiple threads will be writing to a StreamObserver concurrently, the application must synchronize calls.
```
The fix is in this commit - https://github.com/apache/incubator-eventmesh/pull/723/commits/48ab8d36e2fafe959fe4db27fc6d644457dd55e6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1034198696
> I run the `AsyncPublishInstance` and `EventmeshAsyncSubscribe` under the `grpc` module, got following error:
>
> * Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.
> 
>
> After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ? 
>
> this error is not inevitable, please take a look, thanks. @jinrongluo
Thanks @xwm1992 The root cause of this issue is that Grpc StreamObserver is not thread safe. The Java doc is here:
https://grpc.github.io/grpc-java/javadoc/io/grpc/stub/StreamObserver.html
```
Since individual StreamObservers are not thread-safe, if multiple threads will be writing to a StreamObserver concurrently, the application must synchronize calls.
```
The fix is in this commit - https://github.com/apache/incubator-
eventmesh/pull/723/commits/48ab8d36e2fafe959fe4db27fc6d644457dd55e6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1034548629
I will merge to branch, we could continue review, test and bugfix. @jinrongluo @qqeasonchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 edited a comment on pull request #723: [Issue #718] update Grpc Message Model name to SimpleMessage
Posted by GitBox <gi...@apache.org>.
xwm1992 edited a comment on pull request #723:
URL: https://github.com/apache/incubator-eventmesh/pull/723#issuecomment-1029799145
I run the `AsyncPublishInstance` and `EventmeshAsyncSubscribe` under the `grpc` module, got following error:
- Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.
After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ?
this error is not inevitable, please take a look, thanks.
@jinrongluo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org