You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/11/16 13:25:49 UTC
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16724
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
IMPALA-10330 Fix build error on aarch64 platform
Recently, impala was built failed on aarch64 platform because of
Kudu cannot be built successfully on aarch64. So this commit will
change kudu version to 6a7cadc74 which can be built successfully
on aarch64.
Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/24/16724/1
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1:
I'll do a test build before merging.
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Nov 2020 16:34:55 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1:
Tests passed on the other commit, so I'll merge
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 23:19:29 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1:
https://gerrit.cloudera.org/#/c/16735/
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 01:10:52 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 23:19:17 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Nov 2020 16:34:40 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1:
Build is 62-ab817885e4. I guess we should check that this works with Impala before merging. But it sounds like maybe this won't solve the problem?
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2020 01:08:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
Patch Set 1:
I ran the ARM jobs on jenkins.impala.io, and I'm not able to reproduce the Kudu build failure on 2f5605dfc. These jobs build native-toolchain from scratch before running.
Ubuntu 16: Passed all tests https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-ARM/4/
Ubuntu 18: Got past the native toolchain build, now building Impala https://jenkins.impala.io/job/ubuntu-18.04-from-scratch-ARM/5/
I think we need to find out exactly what broke, because it isn't a clear build issue.
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Nov 2020 21:37:51 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16724 )
Change subject: IMPALA-10330 Fix build error on aarch64 platform
......................................................................
IMPALA-10330 Fix build error on aarch64 platform
Recently, impala was built failed on aarch64 platform because of
Kudu cannot be built successfully on aarch64. So this commit will
change kudu version to 6a7cadc74 which can be built successfully
on aarch64.
Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Reviewed-on: http://gerrit.cloudera.org:8080/16724
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52db2b77c3cfa7d4e9ee8a6f8c394bdb475f0dcd
Gerrit-Change-Number: 16724
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>