You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (Created) (JIRA)" <ji...@apache.org> on 2012/02/06 00:43:59 UTC
[jira] [Created] (LUCENE-3754) Store generated archive manifests in
per-module output directories
Store generated archive manifests in per-module output directories
------------------------------------------------------------------
Key: LUCENE-3754
URL: https://issues.apache.org/jira/browse/LUCENE-3754
Project: Lucene - Java
Issue Type: Improvement
Reporter: Steven Rowe
Assignee: Steven Rowe
Priority: Minor
Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3754) Store generated archive manifests
in per-module output directories
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208544#comment-13208544 ]
Steven Rowe commented on LUCENE-3754:
-------------------------------------
Committed to trunk.
Backporting to branch_3x now.
> Store generated archive manifests in per-module output directories
> ------------------------------------------------------------------
>
> Key: LUCENE-3754
> URL: https://issues.apache.org/jira/browse/LUCENE-3754
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3754.patch, LUCENE-3754.patch
>
>
> Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3754) Store generated archive manifests
in per-module output directories
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207530#comment-13207530 ]
Steven Rowe commented on LUCENE-3754:
-------------------------------------
My motivation for this issue was to try to get the jar produced by {{ant generate-maven-artifacts}} be the exact same as that produced by {{ant dist}}, but it is not, even though all file contents, including the manifest, are identical. The metadata in the jar must be different, because the jars produced by these two are the same size, and all their files' contents are identical. I tried adding {{update="true"}} to the {{<jar>}} task used to build the jars, so that the files inside would be updated instead of completely regenerated, and
while the jar file was successfully updated, the two jars still were not identical.
So I'm not sure whether this should be committed. {{ant generate-maven-artifacts}} will have to take another tack to enable its jars to be identical to those produced by {{ant dist}}.
> Store generated archive manifests in per-module output directories
> ------------------------------------------------------------------
>
> Key: LUCENE-3754
> URL: https://issues.apache.org/jira/browse/LUCENE-3754
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3754.patch
>
>
> Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3754) Store generated archive manifests
in per-module output directories
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207892#comment-13207892 ]
Robert Muir commented on LUCENE-3754:
-------------------------------------
+1
> Store generated archive manifests in per-module output directories
> ------------------------------------------------------------------
>
> Key: LUCENE-3754
> URL: https://issues.apache.org/jira/browse/LUCENE-3754
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3754.patch, LUCENE-3754.patch
>
>
> Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3754) Store generated archive manifests
in per-module output directories
Posted by "Steven Rowe (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe resolved LUCENE-3754.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.6
Lucene Fields: New,Patch Available (was: New)
Committed to branch_3x.
> Store generated archive manifests in per-module output directories
> ------------------------------------------------------------------
>
> Key: LUCENE-3754
> URL: https://issues.apache.org/jira/browse/LUCENE-3754
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3754.patch, LUCENE-3754.patch
>
>
> Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3754) Store generated archive manifests in
per-module output directories
Posted by "Steven Rowe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe updated LUCENE-3754:
--------------------------------
Attachment: LUCENE-3754.patch
This version of the patch only provides per-artifact manifest files - these manifest files are always rebuilt, as is currently the case. (I'd rather not make manifests the only part of the build that can get stale between {{ant clean}} invocations.)
The patch also contains a new macro {{<solr-jarify>}}, which provides Solr-specific default attributes, and then calls {{<jarify>}}, so that these values don't have to be specified everywhere in Solr build files - I noticed that one of the Solr {{<jarify>}} invocations was missing a Solr-specific value.
The manifest filename can now have more than one value in a module, though only the facet module uses this capability right now, to provide a different value in the manifest for the examples jar.
Unless there are objections, I will commit this tomorrow.
> Store generated archive manifests in per-module output directories
> ------------------------------------------------------------------
>
> Key: LUCENE-3754
> URL: https://issues.apache.org/jira/browse/LUCENE-3754
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3754.patch, LUCENE-3754.patch
>
>
> Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3754) Store generated archive manifests in
per-module output directories
Posted by "Steven Rowe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe updated LUCENE-3754:
--------------------------------
Attachment: LUCENE-3754.patch
Patch that puts each generated manifest in its own place, and also allows modules to have more than one manifest, e.g. modules/facet/, which has a separate manifest for its example jar.
> Store generated archive manifests in per-module output directories
> ------------------------------------------------------------------
>
> Key: LUCENE-3754
> URL: https://issues.apache.org/jira/browse/LUCENE-3754
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3754.patch
>
>
> Currently, generated archive manifests are all stored in the same location, so each module's build overwrites the previously built module's manifest. Locating these files in the per-module build dirs will allow them to be rebuilt only when necessary, rather than every time a module's {{jar}} target is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org