You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/29 16:58:20 UTC
[GitHub] [incubator-yunikorn-site] kingamarton opened a new pull request #36: [YUNIKORN-525] Update Application states doc
kingamarton opened a new pull request #36:
URL: https://github.com/apache/incubator-yunikorn-site/pull/36
Updated the Completed state definition and extended the documentation with the Expired state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on a change in pull request #36: [YUNIKORN-525] Update Application states doc
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #36:
URL: https://github.com/apache/incubator-yunikorn-site/pull/36#discussion_r571997985
##########
File path: docs/design/scheduler_object_states.md
##########
@@ -67,6 +69,7 @@ The events that can trigger a state change:
* Wait: mark an application as idle (source: core scheduler)
* Complete: mark an application as complete (source: resource manager)
* Kill: kill an application (source: resource manager)
+* Expire: progress the application to the expired state and remove it from the scheduler (source: core scheduler)
Here is a diagram that shows the states with the event that causes the state to change:
Review comment:
The looplab/fsm code allows generating a graphviz file via `fsm.Visualize(state-machine)`.
This file can be converted using the `dot` tool or other online tools into a svg or png file.
Just tracking for posterity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on a change in pull request #36: [YUNIKORN-525] Update Application states doc
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #36:
URL: https://github.com/apache/incubator-yunikorn-site/pull/36#discussion_r568609725
##########
File path: docs/design/scheduler_object_states.md
##########
@@ -52,8 +52,10 @@ Containers/pods can be added to and removed from the application.
This state is part of the normal scheduling cycle.
* Waiting: An application that has no pending requests or running containers/pod will be waiting.
This state shows that the application has not been marked completed yet but currently is not actively being scheduled.
-* Completed: The resource manager has signalled that the application is done.
-This is a final state. The application cannot change state after entering.
+* Completed: An application is considered completed when it has been in the waiting state for a defined time period.
+The current timeout is set to 30 seconds.
+* Expired: The completed application is tracked for a period of time, after that is expired and deleted from the scheduler.
+THis is a final state and after this state the application cannot be tracked anymore.
Review comment:
typo in `THis`
##########
File path: docs/design/scheduler_object_states.md
##########
@@ -52,8 +52,10 @@ Containers/pods can be added to and removed from the application.
This state is part of the normal scheduling cycle.
* Waiting: An application that has no pending requests or running containers/pod will be waiting.
This state shows that the application has not been marked completed yet but currently is not actively being scheduled.
-* Completed: The resource manager has signalled that the application is done.
-This is a final state. The application cannot change state after entering.
+* Completed: An application is considered completed when it has been in the waiting state for a defined time period.
Review comment:
We should add that a completed application can only move to expired and cannot move back into a scheduling state like running or waiting.
##########
File path: docs/design/scheduler_object_states.md
##########
@@ -67,6 +69,7 @@ The events that can trigger a state change:
* Wait: mark an application as idle (source: core scheduler)
* Complete: mark an application as complete (source: resource manager)
Review comment:
We now generate this state event in the core not the resource manager.
##########
File path: docs/design/scheduler_object_states.md
##########
@@ -67,6 +69,7 @@ The events that can trigger a state change:
* Wait: mark an application as idle (source: core scheduler)
* Complete: mark an application as complete (source: resource manager)
* Kill: kill an application (source: resource manager)
+* Expire: progress the application to the expired state and remove it from the scheduler (source: core scheduler)
Here is a diagram that shows the states with the event that causes the state to change:
Review comment:
We need to update this diagram. Let me know if you need help on generating the diagram.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s closed pull request #36: [YUNIKORN-525] Update Application states doc
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #36:
URL: https://github.com/apache/incubator-yunikorn-site/pull/36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on pull request #36: [YUNIKORN-525] Update Application states doc
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #36:
URL: https://github.com/apache/incubator-yunikorn-site/pull/36#issuecomment-783909945
change merged, closing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org