You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/30 23:28:59 UTC
[GitHub] [arrow] jonkeane opened a new pull request #9051: ARROW-10668: [R] Support for the .data pronoun
jonkeane opened a new pull request #9051:
URL: https://github.com/apache/arrow/pull/9051
and tests for the .env pronoun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9051:
URL: https://github.com/apache/arrow/pull/9051#issuecomment-752991160
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=h1) Report
> Merging [#9051](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=desc) (39a1d7b) into [master](https://codecov.io/gh/apache/arrow/commit/2f6874158e3d94bd5eb31765c2550dce8d015c19?el=desc) (2f68741) will **decrease** coverage by `0.25%`.
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9051 +/- ##
==========================================
- Coverage 82.87% 82.61% -0.26%
==========================================
Files 201 202 +1
Lines 49737 50052 +315
==========================================
+ Hits 41219 41351 +132
- Misses 8518 8701 +183
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `91.94% <ø> (ø)` | |
| [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <ø> (-0.04%)` | :arrow_down: |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <ø> (ø)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.49% <ø> (ø)` | |
| [rust/arrow/src/util/test\_util.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC90ZXN0X3V0aWwucnM=) | `90.90% <ø> (ø)` | |
| [rust/datafusion/examples/flight\_server.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL2ZsaWdodF9zZXJ2ZXIucnM=) | `0.00% <0.00%> (ø)` | |
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `81.25% <ø> (ø)` | |
| [rust/datafusion/src/datasource/datasource.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2RhdGFzb3VyY2UucnM=) | `100.00% <ø> (ø)` | |
| [rust/datafusion/src/datasource/empty.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2VtcHR5LnJz) | `70.58% <ø> (ø)` | |
| [rust/datafusion/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `88.26% <0.00%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=footer). Last update [4e57002...39a1d7b](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9051:
URL: https://github.com/apache/arrow/pull/9051#issuecomment-752994186
Passing R CI: https://github.com/jonkeane/arrow/actions/runs/454721137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9051:
URL: https://github.com/apache/arrow/pull/9051#discussion_r550358517
##########
File path: r/R/dplyr.R
##########
@@ -265,6 +267,8 @@ filter_mask <- function(.data) {
# Then add the column references
# Renaming is handled automatically by the named list
env_bind(f_env, !!!lapply(.data$selected_columns, var_binder))
+ # Then bind the data pronoun
+ env_bind(f_env, .data = data_pronoun)
Review comment:
What about this (and delete the data_pronoun defs above)?
```suggestion
data_pronoun <- lapply(.data$selected_columns, var_binder)
env_bind(f_env, !!!data_pronoun)
# Then bind the data pronoun
env_bind(f_env, .data = data_pronoun)
```
I think L261 will miss the column renaming but this will pick it up (and should be marginally more efficient)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io removed a comment on pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
codecov-io removed a comment on pull request #9051:
URL: https://github.com/apache/arrow/pull/9051#issuecomment-752991160
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=h1) Report
> Merging [#9051](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=desc) (39a1d7b) into [master](https://codecov.io/gh/apache/arrow/commit/2f6874158e3d94bd5eb31765c2550dce8d015c19?el=desc) (2f68741) will **decrease** coverage by `0.25%`.
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9051 +/- ##
==========================================
- Coverage 82.87% 82.61% -0.26%
==========================================
Files 201 202 +1
Lines 49737 50052 +315
==========================================
+ Hits 41219 41351 +132
- Misses 8518 8701 +183
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `91.94% <ø> (ø)` | |
| [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <ø> (-0.04%)` | :arrow_down: |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <ø> (ø)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.49% <ø> (ø)` | |
| [rust/arrow/src/util/test\_util.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC90ZXN0X3V0aWwucnM=) | `90.90% <ø> (ø)` | |
| [rust/datafusion/examples/flight\_server.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL2ZsaWdodF9zZXJ2ZXIucnM=) | `0.00% <0.00%> (ø)` | |
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `81.25% <ø> (ø)` | |
| [rust/datafusion/src/datasource/datasource.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2RhdGFzb3VyY2UucnM=) | `100.00% <ø> (ø)` | |
| [rust/datafusion/src/datasource/empty.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2VtcHR5LnJz) | `70.58% <ø> (ø)` | |
| [rust/datafusion/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `88.26% <0.00%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/arrow/pull/9051/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=footer). Last update [4e57002...39a1d7b](https://codecov.io/gh/apache/arrow/pull/9051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9051:
URL: https://github.com/apache/arrow/pull/9051#issuecomment-752794206
https://issues.apache.org/jira/browse/ARROW-10668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9051:
URL: https://github.com/apache/arrow/pull/9051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9051: ARROW-10668: [R] Support for the .data pronoun
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9051:
URL: https://github.com/apache/arrow/pull/9051#issuecomment-752791737
Can you add a news bullet for this (making sure you're rebased on latest master)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org