[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8272: optimize unstandard code

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #8272:
URL: https://github.com/apache/dubbo/pull/8272#discussion_r670356601



##########
File path: dubbo-common/src/test/java/org/apache/dubbo/config/context/ConfigManagerTest.java
##########
@@ -267,7 +267,7 @@ public void testConfigMode() {
                 getConfigManager().addConfig(applicationConfig2);
                 fail("strict mode cannot add two application configs");
             } catch (Exception e) {
-                assertEquals(IllegalStateException.class, e.getClass());

Review comment:
       We should not theat that all kinds of exception are safe enough, some contains serialization threat.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org