You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/16 11:25:05 UTC
[GitHub] [airflow] potiuk opened a new pull request #13714: Add open id dependency
potiuk opened a new pull request #13714:
URL: https://github.com/apache/airflow/pull/13714
Please check only the last commit. as it is based on #13654
Seems that python3-openid dependency is not properly solved by tools
like poetry (it is properly resolved by pip). The result is
that old version of python3-openid is installed when poetry is
used and errors when initdb is run.
While we do not use poetry as an official installation mechanism
this happens frequently enought and it is easy enough to fix
that we can add this dependency to make it easier for
poetry users.
Related to #13711 #13558 #13149
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#issuecomment-761640169
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#discussion_r559039422
##########
File path: setup.cfg
##########
@@ -122,6 +122,8 @@ install_requires =
python-dateutil>=2.3, <3
python-nvd3~=0.15.0
python-slugify>=3.0.0,<5.0
+ # Required for flask-openID which comes with flask-appbuilder
Review comment:
```suggestion
# Required for flask-openID which comes with flask-appbuilder in case of poetry installation
# earlier versions of the dependency are installed but they do not work for Python 3
# (pip installs the right version).
# More info: https://github.com/apache/airflow/issues/13149#issuecomment-748705193
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13714:
URL: https://github.com/apache/airflow/pull/13714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#discussion_r559038988
##########
File path: setup.cfg
##########
@@ -122,6 +122,8 @@ install_requires =
python-dateutil>=2.3, <3
python-nvd3~=0.15.0
python-slugify>=3.0.0,<5.0
+ # Required for flask-openID which comes with flask-appbuilder
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#issuecomment-761627603
I am also on the fence but we already have three issues raised by poetry users. and we can expect more issues if it continues to fail build. The aim is not to fix poetry installation, but at least give the poetry users clear indication of dependency problems. Right now they have a compilation error that is rather misleading so no wonder they open issue for it.
According to https://github.com/apache/airflow/issues/13149#issuecomment-748705193 it works when added as direct dependency for poetry, so i believe it should work when we add it to install requires directly rather than transitive dependency of FAB, and this is the version that is currently installed when pip installs it.
I'd say no harm with adding it just to prevent people from opening new issues about it. We are not fixing poetry installation with that one. It will likely not work still.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#discussion_r559037563
##########
File path: setup.cfg
##########
@@ -122,6 +122,8 @@ install_requires =
python-dateutil>=2.3, <3
python-nvd3~=0.15.0
python-slugify>=3.0.0,<5.0
+ # Required for flask-openID which comes with flask-appbuilder
Review comment:
Can you add a comment here on which we have specifically added it (about poetry) and maybe a link to this PR or one of your comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13714: Add open id dependency
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#issuecomment-761624533
I am on the fence with this one, this does not guarantee it will continue working with poetry in future.
Does it solve this https://github.com/apache/airflow/issues/13149#issuecomment-754107541?
The person here suggested they had to remove `python-openid`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org