[jira] Issue Comment Edited: (OFBIZ-1590) Introduction of new reservation entities

["Valentina Sirkova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569385#action_12569385 ] 

valentina edited comment on OFBIZ-1590 at 2/15/08 3:38 PM:
-------------------------------------------------------------------

Here is the first comment.

1. You have removed my extended field "overbooked" for storing overbooking data in AccommodationMap. Where do you think of placing it? I did not see it anywhere in the patches.
2. Also I noticed you have not extended ShoppingListItem with spot and map fields.
3.In Spot entity you use nrOfSpaces, while it was suggested to use numberOfSpaces.


      was (Author: valentina):
    Here is the first comment.

1. I do not understand why you have cut the relationship of the AccommodationMap to the AccommodationSpot? What are the reasons for that? I really don`t understand.?
2. You have removed my extended field "overbooked" for storing overbooking data in AccommodationMap. Where do you think of placing it? I did not see it anywhere in the patches.
3. Also I noticed you have not extended ShoppingListItem with spot and map fields.
4. Why do you extend all entities with mapId field??? Isn`t it enough to use the spotId field only?? If you keep these two entities related you just need the spot i guess...
5. In Spot entity you use nrOfSpaces, while it was suggested to use numberOfSpaces.
  
> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book". 
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.