[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r341714270
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java
 ##########
 @@ -0,0 +1,50 @@
+package org.apache.helix.rest.server.service;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.helix.ZNRecord;
+import org.apache.helix.manager.zk.client.HelixZkClient;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class PropertyStoreService {
 
 Review comment:
   Let's use ZKClient directly at this PR, it's just simple. My latest commit the Service class is no longer used at all. I've taken a look at the ZkHelixPropertyStore class which provides a lot of overheads that are not needed at all in Helix API service. 
   
   Ideally, I will prefer to use ZkBaseDataAccessor with the Non-ZnRecord custom serializer support(add a getBaseDataAccesor method in abstract class)  (will be my next PR). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org