You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by EMaher <gi...@git.apache.org> on 2016/03/25 03:30:21 UTC

[GitHub] lucenenet pull request: LUCENET-555 Removing dependency on externa...

GitHub user EMaher opened a pull request:

    https://github.com/apache/lucenenet/pull/163

    LUCENET-555 Removing dependency on external zip library.

    - Modifying CompressionMode to use System.IO.Compression.DeflateStream and remove dependency on external zip library.  Verfied AbstractCompressionMode tests passed.
    - Modifying CompressionTools to use System.IO.Compression.DeflateStream and remove dependency on external zip library.
    - Removing unused fuction in TestUtils that depended on external zip library.
    - Adding ignore for project.lock.json files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/conniey/lucenenet emaher/removeZipLib

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit e218ff63d0b22cbe39543986f0382f241cf47c24
Author: Elizabeth Maher <el...@microsoft.com>
Date:   2016-03-24T22:42:32Z

    LUCENET-555 Removing dependency on external zip library.
    
    Adding ignore for project.lock.json files.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: LUCENET-555 Removing dependency on externa...

Posted by EMaher <gi...@git.apache.org>.
Github user EMaher commented on the pull request:

    https://github.com/apache/lucenenet/pull/163#issuecomment-201307599
  
    It is the string interpretation causing the build to fail.  My apologies.  https://github.com/apache/lucenenet/pull/164 removes the use of the C# 6 features.  I'll make sure to avoid until C# 6 features until the CI build is ready for them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: LUCENET-555 Removing dependency on externa...

Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/163#issuecomment-201204537
  
    @EMaher hey, merging this broke compilation (should have tried it locally first!). Can you please have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: LUCENET-555 Removing dependency on externa...

Posted by Tasteful <gi...@git.apache.org>.
Github user Tasteful commented on the pull request:

    https://github.com/apache/lucenenet/pull/163#issuecomment-201215629
  
    It's probably failing for the interpolated string (https://msdn.microsoft.com/en-us/library/dn961160.aspx) on https://github.com/apache/lucenenet/commit/e218ff63d0b22cbe39543986f0382f241cf47c24#diff-343b91381036b34a5e84eebc117858d8R241 
    
    Visual Studio 2015 is using Roslyn for compilation (and usage of C#6). TC probably using the old compiler and cant use the C#6 features.
    
    Enable the Roslyn compiler on the TC can probably be done with the Microsoft.CodeDom.Providers.DotNetCompilerPlatform/Microsoft.Net.Compilers nuget-package or the codebase should only use earlier C# specification.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: LUCENET-555 Removing dependency on externa...

Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/163#issuecomment-201195415
  
    Looks good, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: LUCENET-555 Removing dependency on externa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucenenet/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---