You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2018/12/07 14:43:43 UTC

Review Request 69526: RANGER-2308: User role user should not able to access usersync audit report if it does not have permissions on the audit module.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69526/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2308
    https://issues.apache.org/jira/browse/RANGER-2308


Repository: ranger


Description
-------

Currently user is having default access to usersync audit report but it be should able to access the report only when he is having access in audit module. without that user can't see details in the UI which is not as per the default behaviour of dashboard for user role users.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 941691aaa 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e1a6b5859 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 471052f62 


Diff: https://reviews.apache.org/r/69526/diff/1/


Testing
-------

Tested at local with patch.


Thanks,

Pradeep Agrawal

Re: Review Request 69526: RANGER-2308: User role user should not able to access usersync audit report if it does not have permissions on the audit module.

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69526/#review211245
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 10, 2018, 6 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69526/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2018, 6 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2308
>     https://issues.apache.org/jira/browse/RANGER-2308
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently user is having default access to usersync audit report but it be should able to access the report only when he is having access in audit module. without that user can't see details in the UI which is not as per the default behaviour of dashboard for user role users.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 941691aaa 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e1a6b5859 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 865e115d3 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 471052f62 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a8e6e61a0 
> 
> 
> Diff: https://reviews.apache.org/r/69526/diff/2/
> 
> 
> Testing
> -------
> 
> Tested at local with patch.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 69526: RANGER-2308: User role user should not able to access usersync audit report if it does not have permissions on the audit module.

Posted by Mehul Parikh <me...@freestoneinfotech.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69526/#review211273
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Dec. 10, 2018, 6 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69526/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2018, 6 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2308
>     https://issues.apache.org/jira/browse/RANGER-2308
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently user is having default access to usersync audit report but it be should able to access the report only when he is having access in audit module. without that user can't see details in the UI which is not as per the default behaviour of dashboard for user role users.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 941691aaa 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e1a6b5859 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 865e115d3 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 471052f62 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a8e6e61a0 
> 
> 
> Diff: https://reviews.apache.org/r/69526/diff/2/
> 
> 
> Testing
> -------
> 
> Tested at local with patch.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 69526: RANGER-2308: User role user should not able to access usersync audit report if it does not have permissions on the audit module.

Posted by Pradeep Agrawal <pr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69526/
-----------------------------------------------------------

(Updated Dec. 10, 2018, 6 a.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy.


Changes
-------

Updated patch.


Bugs: RANGER-2308
    https://issues.apache.org/jira/browse/RANGER-2308


Repository: ranger


Description
-------

Currently user is having default access to usersync audit report but it be should able to access the report only when he is having access in audit module. without that user can't see details in the UI which is not as per the default behaviour of dashboard for user role users.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 941691aaa 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e1a6b5859 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 865e115d3 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 471052f62 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a8e6e61a0 


Diff: https://reviews.apache.org/r/69526/diff/2/

Changes: https://reviews.apache.org/r/69526/diff/1-2/


Testing
-------

Tested at local with patch.


Thanks,

Pradeep Agrawal