You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/07 13:24:42 UTC
[GitHub] [hadoop-ozone] fapifta opened a new pull request #535: HDDS-2946.
Rename audit log should contain both srcKey and dstKey not just key
fapifta opened a new pull request #535: HDDS-2946. Rename audit log should contain both srcKey and dstKey not just key
URL: https://github.com/apache/hadoop-ozone/pull/535
#478 What changes were proposed in this pull request?
In the audit log of a rename request we just log the key to be renamed. The purpose of this PR is to replace key to srcKey and dstKey in the audit log message in case of a rename.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2946
## How was this patch tested?
I haven't find any particular junit test that tests actual audit log messages, and I haven't added one, though I have this patch applied on a cluster, and used the new type of audit log to trace down multiple renames properly. I am happy to discuss how to add a junit test if there is any place for it, and if there is any reason to test the particular queries audit contents, I don't see it necessary as the general facilities we are using for audit log message creation are already tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #535: HDDS-2946. Rename
audit log should contain both srcKey and dstKey not just key
Posted by GitBox <gi...@apache.org>.
elek closed pull request #535: HDDS-2946. Rename audit log should contain both srcKey and dstKey not just key
URL: https://github.com/apache/hadoop-ozone/pull/535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org