You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/07/13 17:58:05 UTC

[GitHub] [trafficserver] zwoop opened a new issue, #10028: CID 1513216: Security best practices violations

zwoop opened a new issue, #10028:
URL: https://github.com/apache/trafficserver/issues/10028

   ```
   *** CID 1513216:  Security best practices violations  (TOCTOU)
   /lib/swoc/src/[swoc_file.cc](http://swoc_file.cc/): 371 in swoc::_1_5_1::file::remove_all(const swoc::_1_5_1::file::path &, std::error_code &)()
   365       uintmax_t zret = 0;
   366     
   367       struct ::stat s;
   368       if (p.empty()) {
   369         ec = std::error_code(EINVAL, std::system_category());
   370         return zret;
      CID 1513216:  Security best practices violations  (TOCTOU)
      Calling function "stat" to perform check on "p->c_str()".
   371       } else if (::stat(p.c_str(), &s) < 0) {
   372         ec = std::error_code(errno, std::system_category());
   373         return zret;
   374       } else if (S_ISREG(s.st_mode)) { // regular file, try to remove it!
   375         if (unlink(p.c_str()) != 0) {
   376           ec = std::error_code(errno, std::system_category());
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop commented on issue #10028: CID 1513216: Security best practices violations

Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on issue #10028:
URL: https://github.com/apache/trafficserver/issues/10028#issuecomment-1634705419

   FP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop closed issue #10028: CID 1513216: Security best practices violations

Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop closed issue #10028: CID 1513216:  Security best practices violations
URL: https://github.com/apache/trafficserver/issues/10028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org