You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2016/06/19 07:45:20 UTC

svn commit: r1749137 - in /maven/shared/trunk/maven-project-utils/src: main/java/org/apache/maven/shared/project/utils/AnsiUtils.java test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java

Author: hboutemy
Date: Sun Jun 19 07:45:20 2016
New Revision: 1749137

URL: http://svn.apache.org/viewvc?rev=1749137&view=rev
Log:
[MSHARED-562] simplified API: removed append methods for primitives since autoboxing provides translation into Object

Added:
    maven/shared/trunk/maven-project-utils/src/test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java   (with props)
Modified:
    maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/AnsiUtils.java

Modified: maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/AnsiUtils.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/AnsiUtils.java?rev=1749137&r1=1749136&r2=1749137&view=diff
==============================================================================
--- maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/AnsiUtils.java (original)
+++ maven/shared/trunk/maven-project-utils/src/main/java/org/apache/maven/shared/project/utils/AnsiUtils.java Sun Jun 19 07:45:20 2016
@@ -182,18 +182,6 @@ public class AnsiUtils
         return this;
     }
 
-    public AnsiUtils a( boolean value )
-    {
-        ansi.a( value );
-        return this;
-    }
-
-    public AnsiUtils a( char value )
-    {
-        ansi.a( value );
-        return this;
-    }
-
     public AnsiUtils a( char[] value, int offset, int len )
     {
         ansi.a( value, offset, len );
@@ -216,30 +204,6 @@ public class AnsiUtils
     {
         ansi.a( value );
         return this;
-    }
-
-    public AnsiUtils a( double value )
-    {
-        ansi.a( value );
-        return this;
-    }
-
-    public AnsiUtils a( float value )
-    {
-        ansi.a( value );
-        return this;
-    }
-
-    public AnsiUtils a( int value )
-    {
-        ansi.a( value );
-        return this;
-    }
-
-    public AnsiUtils a( long value )
-    {
-        ansi.a( value );
-        return this;
     }
 
     public AnsiUtils a( Object value )

Added: maven/shared/trunk/maven-project-utils/src/test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-project-utils/src/test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java?rev=1749137&view=auto
==============================================================================
--- maven/shared/trunk/maven-project-utils/src/test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java (added)
+++ maven/shared/trunk/maven-project-utils/src/test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java Sun Jun 19 07:45:20 2016
@@ -0,0 +1,65 @@
+package org.apache.maven.shared.project.utils;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.shared.project.utils.AnsiUtils.ansi;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+
+import org.fusesource.jansi.Ansi;
+import org.junit.Test;
+
+public class AnsiUtilsTest
+{
+    @Test
+    public void constructors()
+    {
+        boolean enabled = Ansi.isEnabled();
+        try
+        {
+            // check that ANSI color disable is taken into account
+            Ansi.setEnabled( false );
+            assertEquals( "test", ansi().error().a( "test" ).reset().toString() );
+            assertEquals( "test", ansi( 16 ).error().a( "test" ).reset().toString() );
+            assertEquals( "test", ansi( new StringBuilder() ).error().a( "test" ).reset().toString() );
+    
+            Ansi.setEnabled( true );
+            assertNotEquals( "test", ansi().error().a( "test" ).reset().toString() );
+            assertNotEquals( "test", ansi( 16 ).error().a( "test" ).reset().toString() );
+            assertNotEquals( "test", ansi( new StringBuilder() ).error().a( "test" ).reset().toString() );
+        }
+        finally
+        {
+            Ansi.setEnabled( enabled );
+        }
+    }
+
+    @Test
+    public void appendText()
+    {
+        // autoboxing of primitives to Object
+        assertEquals( "12", ansi().a( (int) 12 ).toString() );
+        assertEquals( "-1212", ansi().a( (long) -1212 ).toString() );
+        assertEquals( "1.2", ansi().a( 1.2f ).toString() );
+        assertEquals( "-1.212", ansi().a( -1.212d ).toString() );
+        assertEquals( "true", ansi().a( true ).toString() );
+        assertEquals( "c", ansi().a( 'c' ).toString() );
+    }
+}

Propchange: maven/shared/trunk/maven-project-utils/src/test/java/org/apache/maven/shared/project/utils/AnsiUtilsTest.java
------------------------------------------------------------------------------
    svn:mime-type = text/plain