[GitHub] [tvm] Mousius commented on a diff in pull request #10963: [AutoTVM] Use new target object

[GitBox <gi...@apache.org>]

Mousius commented on code in PR #10963:
URL: https://github.com/apache/tvm/pull/10963#discussion_r848493721


##########
python/tvm/autotvm/measure/measure_methods.py:
##########
@@ -496,7 +497,8 @@ def set_task(self, task):
 def _build_func_common(measure_input, runtime=None, check_gpu=None, build_option=None):
     """Common part for building a configuration"""
     target, task, config = measure_input
-    target, task.target_host = Target.check_and_update_host_consist(target, task.target_host)
+    assert not isinstance(target, (Map, dict)), "It's expected that 'target' is a string here."

Review Comment:
   Can we add a unit test to check this assertion fires correctly if the wrong thing is passed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org