You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/06/15 14:19:29 UTC
svn commit: r1861395 -
/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java
Author: tilman
Date: Sat Jun 15 14:19:29 2019
New Revision: 1861395
URL: http://svn.apache.org/viewvc?rev=1861395&view=rev
Log:
PDFBOX-4071: SonarQube fix
Modified:
pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java
Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java?rev=1861395&r1=1861394&r2=1861395&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java Sat Jun 15 14:19:29 2019
@@ -16,6 +16,7 @@
package org.apache.pdfbox.debugger.ui;
import java.awt.Color;
+import java.awt.Container;
import java.awt.Frame;
import java.io.PrintWriter;
import java.io.StringWriter;
@@ -38,17 +39,6 @@ import javax.swing.text.StyledDocument;
public class LogDialog extends JDialog
{
private static LogDialog instance;
-
- public static void init(Frame owner, JLabel logLabel)
- {
- instance = new LogDialog(owner, logLabel);
- }
-
- public static LogDialog instance()
- {
- return instance;
- }
-
private final JLabel logLabel;
private final JTextPane textPane;
private final JScrollPane scrollPane;
@@ -57,7 +47,7 @@ public class LogDialog extends JDialog
private int warnCount = 0;
private int otherCount = 0;
private int exceptionCount = 0;
-
+
private LogDialog(Frame owner, JLabel logLabel)
{
super(owner);
@@ -69,7 +59,17 @@ public class LogDialog extends JDialog
this.pack();
}
-
+
+ public static void init(Frame owner, JLabel logLabel)
+ {
+ instance = new LogDialog(owner, logLabel);
+ }
+
+ public static LogDialog instance()
+ {
+ return instance;
+ }
+
public void log(String name, String level, Object o, Throwable throwable)
{
StyledDocument doc = textPane.getStyledDocument();
@@ -200,4 +200,18 @@ public class LogDialog extends JDialog
textPane.setText("");
logLabel.setText("");
}
+
+ // these two just to avoid the "overridable method call in constructor" warning
+
+ @Override
+ public final Container getContentPane()
+ {
+ return super.getContentPane();
+ }
+
+ @Override
+ public final void pack()
+ {
+ super.pack();
+ }
}