[jira] Updated: (GERONIMO-26) [patch] added null check to byte array equals and removed unneeded try-catch block

[ji...@codehaus.org]

The following issue has been updated:

    Updater: Brent Worden (mailto:brent@worden.org)
       Date: Tue, 26 Aug 2003 11:08 PM
    Comment:
patch file contains all the aforementioned changes.
    Changes:
             Attachment changed to primitives-test-patch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-26&page=history

---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-26


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-26
    Summary: [patch] added null check to byte array equals and removed unneeded try-catch block
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Time Spent: Unknown
  Remaining: Unknown

    Project: Apache Geronimo
 Components: 
             common

   Assignee: 
   Reporter: Brent Worden

    Created: Tue, 26 Aug 2003 11:08 PM
    Updated: Tue, 26 Aug 2003 11:08 PM

Description:
null checks weren't being performed in the equals(byte[], int, byte[], int, int) method.

remove the try-catch block from equals(byte[], byte[]) method because the length equality check prevents the exception from ever being thrown.

changes are complimented with a full battery of test cases.



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira