[GitHub] [spark] cloud-fan commented on a change in pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #28109:
URL: https://github.com/apache/spark/pull/28109#discussion_r415519133



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -112,6 +113,16 @@ case class CustomShuffleReaderExec private(
     }
   }
 
+  @transient private lazy val skewedSpecs: Option[Seq[PartialReducerPartitionSpec]] = {
+    if (hasSkewedPartition) {
+      Some(partitionSpecs.collect {
+        case p: PartialReducerPartitionSpec => p

Review comment:
       This is very short now. Can we just inline this lazy val?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org