[GitHub] leventov commented on a change in pull request #6370: Introduce SegmentId class

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6370: Introduce SegmentId class
URL: https://github.com/apache/incubator-druid/pull/6370#discussion_r243737551
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/select/SelectQueryQueryToolChest.java
 ##########
 @@ -289,22 +287,22 @@ public Object apply(final Result<SelectResultValue> input)
             DateTime timestamp = granularity.toDateTime(((Number) resultIter.next()).longValue());
 
             Map<String, Integer> pageIdentifier = jsonMapper.convertValue(
-                resultIter.next(), new TypeReference<Map<String, Integer>>() {}
-                );
-            Set<String> dimensionSet = jsonMapper.convertValue(
-                resultIter.next(), new TypeReference<Set<String>>() {}
-            );
-            Set<String> metricSet = jsonMapper.convertValue(
-                resultIter.next(), new TypeReference<Set<String>>() {}
+                resultIter.next(),
+                new TypeReference<Map<String, Integer>>() {}
 
 Review comment:
   I also noticed this thing recently. There are more than a hundred occasions in the codebase. Should be fixed in a separate PR, if anybody will have willpower to do that. Could be spotted with a simple regex `(?<!= )new TypeReference`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org