You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/24 18:19:28 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8762: ARROW-10717 [Rust] [DataFusion] Add support for right join
jorgecarleitao opened a new pull request #8762:
URL: https://github.com/apache/arrow/pull/8762
This PR is built on top of #8743 and adds support for the right join. Nothing very complex to achieve, just though that it would be good to have, for completeness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8762: ARROW-10717 [Rust] [DataFusion] Add support for right join
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8762:
URL: https://github.com/apache/arrow/pull/8762#issuecomment-733187529
https://issues.apache.org/jira/browse/ARROW-10717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #8762: ARROW-10717 [Rust] [DataFusion] Add support for right join
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8762:
URL: https://github.com/apache/arrow/pull/8762#issuecomment-735850164
@jorgecarleitao Could you rebase please when you have time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #8762: ARROW-10717 [Rust] [DataFusion] Add support for right join
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8762:
URL: https://github.com/apache/arrow/pull/8762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #8762: ARROW-10717 [Rust] [DataFusion] Add support for right join
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #8762:
URL: https://github.com/apache/arrow/pull/8762#discussion_r532955833
##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -260,18 +261,23 @@ fn build_batch_from_indices(
// this is just for symmetry of the code below.
let right = vec![right.clone()];
+ let (primary_is_left, primary, secondary) = match join_type {
Review comment:
Maybe this could be called `outer_is_left`, `outer`, and `inner` to use standard terms rather than `primary` and `secondary`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org