You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:21:06 UTC
Review Request 66956: Windows: Added overlapped support to
`os::write`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66956/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
Bugs: MESOS-8674
https://issues.apache.org/jira/browse/MESOS-8674
Repository: mesos
Description
-------
Added overlapped handle support to `os::write`. Now, `os::write` will do
a blocking write no matter the handle type. Also, `os::write_async` will
do an overlapped write on an overlapped handle.
Diffs
-----
3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69
Diff: https://reviews.apache.org/r/66956/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 66956: Windows: Added overlapped support to
`os::write`.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66956/#review202509
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika Jandhyala
On May 4, 2018, 5:21 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66956/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 5:21 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added overlapped handle support to `os::write`. Now, `os::write` will do
> a blocking write no matter the handle type. Also, `os::write_async` will
> do an overlapped write on an overlapped handle.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69
>
>
> Diff: https://reviews.apache.org/r/66956/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 66956: Windows: Added overlapped support to
`os::write`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66956/#review203688
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On May 22, 2018, 3:46 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66956/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 3:46 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added overlapped handle support to `os::write`. Now, `os::write` will do
> a blocking write no matter the handle type. Also, `os::write_async` will
> do an overlapped write on an overlapped handle.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69
>
>
> Diff: https://reviews.apache.org/r/66956/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 66956: Windows: Added overlapped support to
`os::write`.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66956/
-----------------------------------------------------------
(Updated May 22, 2018, 10:46 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
Changes
-------
Updated with Andy's feedback.
Bugs: MESOS-8670
https://issues.apache.org/jira/browse/MESOS-8670
Repository: mesos
Description
-------
Added overlapped handle support to `os::write`. Now, `os::write` will do
a blocking write no matter the handle type. Also, `os::write_async` will
do an overlapped write on an overlapped handle.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69
Diff: https://reviews.apache.org/r/66956/diff/2/
Changes: https://reviews.apache.org/r/66956/diff/1-2/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 66956: Windows: Added overlapped support to
`os::write`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66956/#review202582
-----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/write.hpp
Lines 23-29 (patched)
<https://reviews.apache.org/r/66956/#comment284431>
Same question, should this be a public API?
3rdparty/stout/include/stout/os/windows/write.hpp
Line 29 (original), 32 (patched)
<https://reviews.apache.org/r/66956/#comment284432>
Hm. Maybe `read_write_async` should be `read_async` and `write_async` internally so we don't have to throw away the constness here.
- Andrew Schwartzmeyer
On May 4, 2018, 10:21 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66956/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:21 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added overlapped handle support to `os::write`. Now, `os::write` will do
> a blocking write no matter the handle type. Also, `os::write_async` will
> do an overlapped write on an overlapped handle.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69
>
>
> Diff: https://reviews.apache.org/r/66956/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>