You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 21:52:58 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #9637: [WIP][explore view] add partition as adhoc filter option
codecov-io commented on pull request #9637:
URL: https://github.com/apache/incubator-superset/pull/9637#issuecomment-620874859
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=h1) Report
> Merging [#9637](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `11.81%`.
> The diff coverage is `56.60%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9637 +/- ##
===========================================
- Coverage 70.52% 58.70% -11.82%
===========================================
Files 574 399 -175
Lines 30152 12511 -17641
Branches 3060 3099 +39
===========================================
- Hits 21265 7345 -13920
+ Misses 8776 4984 -3792
- Partials 111 182 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.70% <56.60%> (-0.07%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `57.44% <ø> (-21.28%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | `57.69% <ø> (-23.08%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.78% <38.88%> (-26.13%)` | :arrow_down: |
| [superset-frontend/src/explore/AdhocFilter.js](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NGaWx0ZXIuanM=) | `84.93% <61.53%> (-10.39%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `68.70% <65.00%> (-18.59%)` | :arrow_down: |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [342 more](https://codecov.io/gh/apache/incubator-superset/pull/9637/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=footer). Last update [a6cedaa...dc9b43a](https://codecov.io/gh/apache/incubator-superset/pull/9637?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org