[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #52: require PR reviews and linear history

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko/pull/52#discussion_r1099883068


##########
.asf.yaml:
##########
@@ -28,7 +43,22 @@ github:
     rebase:  true
 
   protected_branches:
-    main: { }
+    main:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Scalafmt

Review Comment:
   As per https://github.com/apache/incubator-pekko-sbt-paradox/pull/7, this needs to be changed to `- Code is formatted` rather than `- Scalafmt`



##########
.asf.yaml:
##########
@@ -28,7 +43,22 @@ github:
     rebase:  true
 
   protected_branches:
-    main: { }
+    main:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Scalafmt
+          - Pull Requests / Check / Headers

Review Comment:
   I would recommend checking that this works in a separately. As per https://github.com/apache/incubator-pekko-sbt-paradox/pull/5#issuecomment-1414453790 otherwise we can freeze the main branch and we have to make an INFRA ticket to unfreeze it. The way I did this I pushed a new branch (ergo `test`), created a PR against `main` that only enables the `contexts` check against `test` and then make another PR against test to figure out if the check is satisfied.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org