You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/05/31 16:30:43 UTC
[native-toolchain-CR] IMPALA-12174: Workaround Kudu repo.spring.io build issue
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19960
Change subject: IMPALA-12174: Workaround Kudu repo.spring.io build issue
......................................................................
IMPALA-12174: Workaround Kudu repo.spring.io build issue
Kudu gets propdeps-plugin from repo.spring.io. This repository
has started restricting acccess and this artifact is no
longer accessible. This patches Kudu to use the equivalent
gradle.plugin.cn.bestwu.gradle:propdeps-plugin. This is
strictly a build plugin and has no functional impact.
This will be removed when Kudu addresses this upstream.
This patch can be backported to older toolchains to avoid
needing custom Kudu versions.
Testing:
- The build succeeds with this change.
Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
---
A source/kudu/0001-IMPALA-12174-Work-around-Kudu-build-issues-with-repo.patch
M source/kudu/build.sh
2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/60/19960/1
--
To view, visit http://gerrit.cloudera.org:8080/19960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
Gerrit-Change-Number: 19960
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-12174: Workaround Kudu repo.spring.io build issue
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19960 )
Change subject: IMPALA-12174: Workaround Kudu repo.spring.io build issue
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
Gerrit-Change-Number: 19960
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 17:06:55 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12174: Workaround Kudu repo.spring.io build issue
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19960 )
Change subject: IMPALA-12174: Workaround Kudu repo.spring.io build issue
......................................................................
IMPALA-12174: Workaround Kudu repo.spring.io build issue
Kudu gets propdeps-plugin from repo.spring.io. This repository
has started restricting acccess and this artifact is no
longer accessible. This patches Kudu to use the equivalent
gradle.plugin.cn.bestwu.gradle:propdeps-plugin. This is
strictly a build plugin and has no functional impact.
This will be removed when Kudu addresses this upstream.
This patch can be backported to older toolchains to avoid
needing custom Kudu versions.
Testing:
- The build succeeds with this change.
Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
Reviewed-on: http://gerrit.cloudera.org:8080/19960
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
A source/kudu/0001-IMPALA-12174-Work-around-Kudu-build-issues-with-repo.patch
M source/kudu/build.sh
2 files changed, 70 insertions(+), 0 deletions(-)
Approvals:
Jason Fehr: Looks good to me, but someone else must approve
Riza Suminto: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
Gerrit-Change-Number: 19960
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[native-toolchain-CR] IMPALA-12174: Workaround Kudu repo.spring.io build issue
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19960 )
Change subject: IMPALA-12174: Workaround Kudu repo.spring.io build issue
......................................................................
Patch Set 1: Verified+1
My toolchain build passes, so going ahead with this
--
To view, visit http://gerrit.cloudera.org:8080/19960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
Gerrit-Change-Number: 19960
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 20:28:49 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12174: Workaround Kudu repo.spring.io build issue
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19960 )
Change subject: IMPALA-12174: Workaround Kudu repo.spring.io build issue
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee742fce4e8fb943872eee2db3489c1b39053d
Gerrit-Change-Number: 19960
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 16:40:11 +0000
Gerrit-HasComments: No