You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/10/19 06:27:01 UTC
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 4:27 a.m.)
Review request for mesos and Michael Park.
Summary (updated)
-----------------
Added prevention of SASL deprecation warnings all around its invocations on OS X.
Bugs: MESOS-3030
https://issues.apache.org/jira/browse/MESOS-3030
Repository: mesos
Description (updated)
-------
see summary.
Diffs (updated)
-----
configure.ac 66f9b32
src/authentication/cram_md5/authenticatee.cpp b03b44a
src/authentication/cram_md5/authenticator.cpp f238872
src/authentication/cram_md5/auxprop.cpp abf0f8d
Diff: https://reviews.apache.org/r/39230/diff/
Testing
-------
./configure && make check
OSX, clang3.7 + gcc4.9
Thanks,
Till Toenshoff
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103099
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39230]
All tests passed.
- Mesos ReviewBot
On Oct. 19, 2015, 4:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 4:27 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103572
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39230]
All tests passed.
- Mesos ReviewBot
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 10:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103885
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 10:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Neil Conway <ne...@gmail.com>.
> On Nov. 2, 2015, 6:44 p.m., Alex Clemmer wrote:
> > configure.ac, line 758
> > <https://reviews.apache.org/r/39230/diff/3/?file=1103165#file1103165line758>
> >
> > Sorry I'm super late to the party. Does it make sense to add these to the CMake build system as well?
Using #pragma would apply to CMake as well, I believe. i.e., should work for cmake as-is.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review104753
-----------------------------------------------------------
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 10:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review104753
-----------------------------------------------------------
configure.ac (line 758)
<https://reviews.apache.org/r/39230/#comment162998>
Sorry I'm super late to the party. Does it make sense to add these to the CMake build system as well?
- Alex Clemmer
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 10:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 10:02 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Removed clang specific pragmas as clang does pick up the GCC specific ones already. Updated configure.ac to also contain the specific comment.
Bugs: MESOS-3030
https://issues.apache.org/jira/browse/MESOS-3030
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
configure.ac 66f9b32
src/authentication/cram_md5/authenticatee.cpp b03b44a
src/authentication/cram_md5/authenticator.cpp f238872
src/authentication/cram_md5/auxprop.cpp abf0f8d
Diff: https://reviews.apache.org/r/39230/diff/
Testing
-------
./configure && make check
OSX, clang3.7 + gcc4.9
Thanks,
Till Toenshoff
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Till Toenshoff <to...@me.com>.
> On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote:
> > Curious if we want to scope these for the whole files? Might be a bit hard to scope this correctly over time.
True that - also I noticed that I can totally not include the clang specific pragma as clang does pick up the GCC specifics already.
> On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote:
> > configure.ac, lines 769-774
> > <https://reviews.apache.org/r/39230/diff/2/?file=1098841#file1098841line769>
> >
> > Could you include the comment here as well?
Aye....
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103488
-----------------------------------------------------------
On Oct. 19, 2015, 4:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 4:27 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 39230: Added prevention of SASL deprecation
warnings all around its invocations on OS X.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103488
-----------------------------------------------------------
Ship it!
Curious if we want to scope these for the whole files? Might be a bit hard to scope this correctly over time.
configure.ac (lines 769 - 774)
<https://reviews.apache.org/r/39230/#comment161547>
Could you include the comment here as well?
- Ben Mahler
On Oct. 19, 2015, 4:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 4:27 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> configure.ac 66f9b32
> src/authentication/cram_md5/authenticatee.cpp b03b44a
> src/authentication/cram_md5/authenticator.cpp f238872
> src/authentication/cram_md5/auxprop.cpp abf0f8d
>
> Diff: https://reviews.apache.org/r/39230/diff/
>
>
> Testing
> -------
>
> ./configure && make check
> OSX, clang3.7 + gcc4.9
>
>
> Thanks,
>
> Till Toenshoff
>
>