You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by markflyhigh <gi...@git.apache.org> on 2017/03/14 20:29:12 UTC
[GitHub] beam pull request #2244: [BEAM-1715] Fix Python WordCount on Dataflow Mismat...
GitHub user markflyhigh opened a pull request:
https://github.com/apache/beam/pull/2244
[BEAM-1715] Fix Python WordCount on Dataflow Mismatch
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
- Add more logs
- Add sleep before verification in order to give more time to have files ready on FS, especially GCS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam python-file-verifier-inconsistency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2244
----
commit c9d9dc45de8e6ad915fdc9bc48e304cb0ac5121d
Author: Mark Liu <ma...@google.com>
Date: 2017-03-14T19:43:45Z
[BEAM-1715] Fix Python WordCount on Dataflow Mismatch
commit 0a76a232a713dd35623d47e4dd40140b4b4f0f74
Author: Mark Liu <ma...@google.com>
Date: 2017-03-14T19:47:18Z
fixup! Remove unused import
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2244: [BEAM-1715] Fix Python WordCount on Dataflow Mismat...
Posted by markflyhigh <gi...@git.apache.org>.
GitHub user markflyhigh reopened a pull request:
https://github.com/apache/beam/pull/2244
[BEAM-1715] Fix Python WordCount on Dataflow Mismatch
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
- Add more logs for debugging
- Add sleep before verification in order to give more time to have files ready on FS, especially GCS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam python-file-verifier-inconsistency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2244
----
commit c9d9dc45de8e6ad915fdc9bc48e304cb0ac5121d
Author: Mark Liu <ma...@google.com>
Date: 2017-03-14T19:43:45Z
[BEAM-1715] Fix Python WordCount on Dataflow Mismatch
commit 0a76a232a713dd35623d47e4dd40140b4b4f0f74
Author: Mark Liu <ma...@google.com>
Date: 2017-03-14T19:47:18Z
fixup! Remove unused import
commit ba31373a62d4f7848dadc91d9b713774ab795873
Author: Mark Liu <ma...@google.com>
Date: 2017-03-15T00:06:57Z
Make sleep time configurable from commandline
commit 08037d289319374401b9189c3a5df27b37b13e33
Author: Mark Liu <ma...@google.com>
Date: 2017-03-15T19:00:11Z
fixup! Fix error sleep_secs type
commit aefd83ab2b7af56dfac988c788eecc2afe9d7165
Author: Mark Liu <ma...@google.com>
Date: 2017-03-17T00:06:38Z
fixup! Sleep in WordcountIT should be optionsal
commit 01040815569fefde981c9681c208cd28d51f8bcd
Author: Mark Liu <ma...@google.com>
Date: 2017-03-22T22:51:03Z
fixup! Improve Comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2244: [BEAM-1715] Fix Python WordCount on Dataflow Mismat...
Posted by markflyhigh <gi...@git.apache.org>.
Github user markflyhigh closed the pull request at:
https://github.com/apache/beam/pull/2244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2244: [BEAM-1715] Fix Python WordCount on Dataflow Mismat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---