You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/22 06:54:35 UTC

[GitHub] [hudi] slfan1989 opened a new pull request, #7030: HUDI-5072. Extract transform duplicate code.

slfan1989 opened a new pull request, #7030:
URL: https://github.com/apache/hudi/pull/7030

   ### Change Logs
   
   When reading the code, I found that the transform methods of MultipleSparkJobExecutionStrategy and SingleSparkJobExecutionStrategy have redundant code. I think we can extract them to make the code cleaner.
   
   ### Impact
   
   none
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1287660494

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7861e37fd386455f33cc630c2d39ffea0605f8d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1291287199

   @nsivabalan Can you help review the code again? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1288139885

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489",
       "triggerID" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ffc01a736a908ccec16134ea3b82a6d51b7833c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1290964247

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489",
       "triggerID" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e22b49fa093f5ba8dafdedc2da6384a7decb1b0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12558",
       "triggerID" : "8e22b49fa093f5ba8dafdedc2da6384a7decb1b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e22b49fa093f5ba8dafdedc2da6384a7decb1b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12558) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1287763404

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7861e37fd386455f33cc630c2d39ffea0605f8d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1288108745

   @xushiyan Can you help review this pr? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #7030:
URL: https://github.com/apache/hudi/pull/7030


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1287659458

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7861e37fd386455f33cc630c2d39ffea0605f8d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1290003220

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489",
       "triggerID" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e22b49fa093f5ba8dafdedc2da6384a7decb1b0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12558",
       "triggerID" : "8e22b49fa093f5ba8dafdedc2da6384a7decb1b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ffc01a736a908ccec16134ea3b82a6d51b7833c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489) 
   * 8e22b49fa093f5ba8dafdedc2da6384a7decb1b0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12558) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1289845520

   > can you check the CI failure.
   
   @nsivabalan Thanks for your help reviewing the code! I will Check the CI failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1288109950

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7861e37fd386455f33cc630c2d39ffea0605f8d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461) 
   * 1ffc01a736a908ccec16134ea3b82a6d51b7833c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1289763050

   can you check the CI failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1288111010

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489",
       "triggerID" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7861e37fd386455f33cc630c2d39ffea0605f8d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461) 
   * 1ffc01a736a908ccec16134ea3b82a6d51b7833c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7030: [HUDI-5072] Extract transform duplicate code.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7030:
URL: https://github.com/apache/hudi/pull/7030#issuecomment-1289997823

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12461",
       "triggerID" : "f7861e37fd386455f33cc630c2d39ffea0605f8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489",
       "triggerID" : "1ffc01a736a908ccec16134ea3b82a6d51b7833c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e22b49fa093f5ba8dafdedc2da6384a7decb1b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8e22b49fa093f5ba8dafdedc2da6384a7decb1b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ffc01a736a908ccec16134ea3b82a6d51b7833c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12489) 
   * 8e22b49fa093f5ba8dafdedc2da6384a7decb1b0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org