You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "ayushtkn (via GitHub)" <gi...@apache.org> on 2023/05/09 09:31:46 UTC

[GitHub] [hive] ayushtkn commented on a diff in pull request #4289: HIVE-27243: Iceberg: Implement Load data via temp table.

ayushtkn commented on code in PR #4289:
URL: https://github.com/apache/hive/pull/4289#discussion_r1188381408


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -330,6 +333,15 @@ public boolean canProvideBasicStatistics() {
     return true;
   }
 
+  @Override
+  public StorageFormatDescriptor supportsLoadData(org.apache.hadoop.hive.metastore.api.Table tbl) {
+    if (tbl.getParameters() != null) {
+      String format = tbl.getParameters().get("write.format.default");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org